t() calls should be avoided , use $this->t() instead in Form Builders

This kind of changes should target 9.1.x now, thanks!

Fixed t() cells dependency injection in Form, kindly review.

Thanks,
Shakti

This should reduce the error count.. a little.

Hi @martin107,

I am checking another test case.

+++ b/core/modules/image/src/Form/ImageStyleEditForm.php
@@ -253,8 +253,8 @@ public function submitForm(array &$form, FormStateInterface $form_state) {
-    parent::save($form, $form_state);
...
+    parent::save($form, $form_state);

Why is this changed? It seems unrelated to t().

shaktik -- Can I ask you to produce an interdiff while you work... it is much easier for us to follow along and give suggestions.

Here is some documentation on how to produce one.

https://www.drupal.org/documentation/git/interdiff

Hi @ martin,

please check attached interdiff, I am trying to fix rest 6 error test failer.

Look for the test with the shortest run time.. ConfigAccessTest

Reading the test class I saw it was looking for a particular block.

$block = $this->placeBlock('system_branding_block');

The system_branding_block has the following annotation

/**
 * Provides a block to display 'Site branding' elements.
 *
 * @Block(
 *   id = "system_branding_block",
 *   admin_label = @Translation("Site branding"),
 *   forms = {
 *     "settings_tray" = "Drupal\system\Form\SystemBrandingOffCanvasForm",
 *   },
 * )
 */

and that told me where to look ...

That SystemBrandingOffCanvasForm was missing the StringTranslationTrait

I hope that explanation helps.

Patch needs re-roll

New patch.

Can someone write an issue summary so we understand what is being fixed here and can discuss the scope of the issue please?

Updating issue summary.

Thanks! The patch is looking good but I found a few more cases that weren't covered:

core/lib/Drupal/Core/Menu/Form/MenuLinkDefaultForm.php:      '#title' => t('Show as expanded'),

core/lib/Drupal/Core/Installer/Form/SiteConfigureForm.php:      $this->messenger()->addWarning(t('All necessary changes to %dir and %file have been made, so you should remove write permissions to them now in order to avoid security risks. If you are unsure how to do so, consult the <a href=":handbook_url">online handbook</a>.', ['%dir' => $settings_dir, '%file' => $settings_file, ':handbook_url' => 'https://www.drupal.org/server-permissions']));

core/modules/system/src/Form/PrepareModulesEntityUninstallForm.php:      'title' => t('Deleting @entity_type_plural', [

core/modules/system/src/Form/PrepareModulesEntityUninstallForm.php:      $context['message'] = t('Deleting items... Completed @percentage% (@current of @total).', ['@percentage' => round(100 * $context['sandbox']['progress'] / $context['sandbox']['max']), '@current' => $context['sandbox']['progress'], '@total' => $context['sandbox']['max']]);

core/modules/system/src/Form/PrepareModulesEntityUninstallForm.php:    \Drupal::messenger()->addStatus(t('All @entity_type_plural have been deleted.', ['@entity_type_plural' => $entity_type_plural]));

core/modules/quickedit/src/Form/QuickEditFieldForm.php:      $entity->revision_log = t('Updated the %field-name field through in-place editing.', ['%field-name' => $entity->get($field_name)->getFieldDefinition()->getLabel()]);

core/modules/config_translation/src/Form/ConfigTranslationFormBase.php:        $definition->setLabel(t('n/a'));

core/modules/views_ui/src/Form/Ajax/ReorderDisplays.php:          '#title' => t('Remove @id', ['@id' => $id]),

Hi,

I am working on it. Will update as soon as possible.

Thanks.

Hi,

Added a patch for the remaining ones. Please review the same and let me know for any observations.

Thanks.

The patch is missing the previous changes, the interdiff shows them being removed.

Hi @longwave,

Thanks for reviewing it. I will add the interdiff and the patch on top of the last patch submitted.

Thanks.

Hi @longwave,

Added the new patch and inerdiff on top of #37. Please review the same and let me know for any other observations.

Thanks.

Hi,

Mistakenly added the interdiff with the '.patch' extension. Adding the right one.

Thanks.

Hi, I have made the changes over the patch in comment #37 and changes asked by @longwave in comment #40. Adding the patch as well as interdiff.
Please ignore this patch.

I have added the wrong patch. Uploading the correct one.

Hi, I have made the changes over the patch in comment #37 and changes asked by @longwave in comment #40. Adding the patch as well as interdiff.

Patch #54 looks good to me!

Set to RTBC.

These are instances where that weren't covered

core/modules/block_content/src/BlockContentTypeForm.php:      '#title' => t('Label')

core/modules/block_content/src/BlockContentTypeForm.php:      '#description' => t("Provide a label for this block type to help identify it in the administration pages."),


core/modules/block_content/src/BlockContentTypeForm.php:      '#description' => t('Enter a description for this block type.'),


core/modules/block_content/src/BlockContentTypeForm.php:      '#title' => t('Description'),


core/modules/block_content/src/BlockContentTypeForm.php:      '#title' => t('Create new revision'),

core/modules/block_content/src/BlockContentTypeForm.php:      '#description' => t('Create a new revision by default for this block type.'),

core/modules/block_content/src/BlockContentTypeForm.php:        '#title' => t('Language settings'),

core/modules/block_content/src/BlockContentTypeForm.php:      '#value' => t('Save'),

core/modules/comment/src/CommentTypeForm.php:      '#title' => t('Label'),

core/modules/comment/src/CommentTypeForm.php:      '#description' => t('Describe this comment type. The text will be displayed on the <em>Comment types</em> administration overview page.'),

core/modules/comment/src/CommentTypeForm.php:      '#title' => t('Description'),

core/modules/comment/src/CommentTypeForm.php:        '#title' => t('Target entity type'),

core/modules/comment/src/CommentTypeForm.php:        '#description' => t('The target entity type can not be changed after the comment type has been created.'),

core/modules/comment/src/CommentTypeForm.php:        '#title' => t('Target entity type'),

core/modules/comment/src/CommentTypeForm.php:        '#title' => t('Language settings'),

core/modules/comment/src/CommentTypeForm.php:      '#value' => t('Save'),

core/modules/menu_ui/src/MenuForm.php:      '#title' => t('Administrative summary'),

core/modules/menu_ui/src/MenuForm.php:      '#title' => t('Menu language'),

core/modules/node/src/NodeTypeForm.php:      '#title' => t('Name'),

core/modules/node/src/NodeTypeForm.php:      '#description' => t('The human-readable name of this content type. This text will be displayed as part of the list on the <em>Add content</em> page. This name must be unique.'),

core/modules/node/src/NodeTypeForm.php:      '#description' => t('A unique machine-readable name for this content type. It must only contain lowercase letters, numbers, and unders
cores. This name will be used for constructing the URL of the %node-add page, in which unders
cores will be converted into hyphens.', [

core/modules/node/src/NodeTypeForm.php:        '%node-add' => t('Add content'),

core/modules/node/src/NodeTypeForm.php:      '#title' => t('Description'),

core/modules/node/src/NodeTypeForm.php:      '#description' => t('This text will be displayed on the <em>Add new content</em> page.'),

core/modules/node/src/NodeTypeForm.php:      '#title' => t('Submission form settings'),

core/modules/node/src/NodeTypeForm.php:      '#title' => t('Title field label'),

core/modules/node/src/NodeTypeForm.php:      '#title' => t('Preview before submitting'),

core/modules/node/src/NodeTypeForm.php:        DRUPAL_DISABLED => t('Disabled'),

core/modules/node/src/NodeTypeForm.php:        DRUPAL_OPTIONAL => t('Optional'),

core/modules/node/src/NodeTypeForm.php:        DRUPAL_REQUIRED => t('Required'),

core/modules/node/src/NodeTypeForm.php:      '#title' => t('Explanation or submission guidelines'),

core/modules/node/src/NodeTypeForm.php:      '#description' => t('This text will be displayed at the top of the page when creating or editing content of this type.'),

core/modules/node/src/NodeTypeForm.php:      '#title' => t('Publishing options'),

core/modules/node/src/NodeTypeForm.php:      '#title' => t('Default options'),

core/modules/node/src/NodeTypeForm.php:        'status' => t('Published'),

core/modules/node/src/NodeTypeForm.php:        'promote' => t('Promoted to front page'),

core/modules/node/src/NodeTypeForm.php:        'sticky' => t('Sticky at top of lists'),

core/modules/node/src/NodeTypeForm.php:        'revision' => t('Create new revision'),

core/modules/node/src/NodeTypeForm.php:      '#description' => t('Users with sufficient access rights will be able to override these options.'),

core/modules/node/src/NodeTypeForm.php:        '#title' => t('Language settings'),

core/modules/node/src/NodeTypeForm.php:      '#title' => t('Display settings'),

core/modules/node/src/NodeTypeForm.php:      '#title' => t('Display author and date information'),

core/modules/node/src/NodeTypeForm.php:      '#description' => t('Author username and publish date will be displayed.'),

core/modules/node/src/NodeTypeForm.php:    $actions['submit']['#value'] = t('Save content type');

core/modules/node/src/NodeForm.php:      '#title' => t('Authoring information'),

core/modules/node/src/NodeForm.php:      '#title' => t('Promotion options'),

core/modules/node/src/NodeForm.php:      '#value' => t('Preview'),

core/modules/responsive_image/src/ResponsiveImageStyleForm.php:      '#description' => t('Select the smallest image style you expect to appear in this space. The fallback image style should only appear on the site if an error occurs.'),

core/modules/shortcut/src/ShortcutSetForm.php:      '#title' => t('Set name'),

core/modules/shortcut/src/ShortcutSetForm.php:      '#description' => t('The new set is created by copying links from your default shortcut set.'),

core/modules/shortcut/src/ShortcutSetForm.php:    $form['actions']['submit']['#value'] = t('Create new set');

core/modules/statistics/src/StatisticsSettingsForm.php:      '#title' => t('Content viewing counter settings'),

core/modules/statistics/src/StatisticsSettingsForm.php:      '#title' => t('Count content views'),

core/modules/statistics/src/StatisticsSettingsForm.php:      '#description' => t('Increment a counter each time content is viewed.'),

core/modules/update/src/UpdateSettingsForm.php:      '#title' => t('Check for updates'),

core/modules/update/src/UpdateSettingsForm.php:        '1' => t('Daily'),

core/modules/update/src/UpdateSettingsForm.php:        '7' => t('Weekly'),

core/modules/update/src/UpdateSettingsForm.php:      '#description' => t('Select how frequently you want to automatically check for new releases of your currently installed modules and themes.'),

core/modules/update/src/UpdateSettingsForm.php:      '#title' => t('Check for updates of uninstalled modules and themes'),

core/modules/update/src/UpdateSettingsForm.php:      '#title' => t('Email addresses to notify when updates are available'),

core/modules/update/src/UpdateSettingsForm.php:      '#description' => t('Whenever your site checks for available updates and finds new releases, it can notify a list of users via email. Put each address on a separate line. If blank, no emails will be sent.'),

core/modules/update/src/UpdateSettingsForm.php:      '#title' => t('Email notification threshold'),

core/modules/update/src/UpdateSettingsForm.php:        'all' => t('All newer versions'),

core/modules/update/src/UpdateSettingsForm.php:        'security' => t('Only security updates'),

core/modules/update/src/UpdateSettingsForm.php:      '#description' => t('You can choose to send email only if a security update is available, or to be notified about all newer versions. If there are updates available of Drupal 
core or any of your installed modules and themes, your site will always print a message on the <a href=":status_report">status report</a> page, and will also display an error message on administration pages if there is a security update.', [':status_report' => Url::fromRoute('system.status')->toString()]),

core/modules/user/src/AccountForm.php:      '#title' => t('Locale settings'),

core/modules/user/src/AccountForm.php:      '#title' => t('Time zone'),

core/modules/user/src/AccountForm.php:      '#description' => t('Select the desired local time and time zone. Dates and times throughout this site will be displayed using this time zone.'),

core/modules/views_ui/src/ViewAddForm.php:      '#title' => t('View basic information'),

core/modules/views_ui/src/ViewAddForm.php:      '#title' => t('View settings'),

Oh, well spotted, my search wasn't good enough to find those forms. Needs work to include those changes too.

Hi, I have uploaded the patch and interdiff as well. In this patch only the instances in the forms are present. Have removed the instances where testForms were covered. We will have another issue for that. Please review.

Thanks @siddhant.bhosale for the Patch #59, looks good to me!

Aplied the patch successfully, and cross verified with code sniffer for any missed files. Seems all covered.

Kindly refer to the attached. Set to RTBC.

@SivaprasadC: The automated testing infrastructure tells us whether the patch applies, so we do not need people to review that. The same goes for coding standards sniffs. Neither are also not sufficient criteria for the issue to be marked "Reviewed and Tested by the Community".

What we do need people to review is whether the issue has a correct scope, whether it passes the core gates, whether the solution completely fixes the problem without introducing other problems, and whether it's the best solution we can come up with. See the patch review guide for more information.

When you do post a review, be sure to describe what you reviewed and how. This helps other reviewers understand why you considered the issue RTBC (and is considered for issue credit).

The patch is currently not applying to 9.1.x, so that at least needs to be fixed.

Hear Updated Patch.

This looks good to me and seems to cover all non-test forms, I can't find any remaining instances.

Double random fail, as far as I can see.

Needs a re-roll for 9.2.x

Re-rolled for 9.2.x

Random fail:

Drupal\Core\Database\SchemaObjectExistsException: Table 'sequences' already exists.

Committed 0b1816c and pushed to 9.2.x. Thanks!

Closed #2806983: Replace non-test usage of t() with injected service as a duplicate of this.