There are some phpcs issues, which needs to be fixed.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kunal.kursija created an issue. See original summary.

kunalkursija’s picture

Adding Patch

kunalkursija’s picture

Status: Active » Needs review
tobiasb’s picture

Component: markup » telephone.module
mallezie’s picture

Status: Needs review » Reviewed & tested by the community

This works as expected. ;-)

cilefen’s picture

Status: Reviewed & tested by the community » Closed (won't fix)

I will quote @dawehner and @alexpott and the usual reply is:

Thank you for your work on cleaning up Drupal core's code style!

In order to fix core coding standards in a maintainable way, all our coding standards issues should be done on a per-rule basis across all of core, rather than fixing standards in individual modules or files. We should also separate fixes where we need to write new documentation from fixes where we need to correct existing standards. This all should be done as part of #2571965: [meta] Fix PHP coding standards in core.

For background information on why we usually will not commit coding standards fixes that aren't scoped in that way, see the core issue scope guidelines, especially the note about coding standards cleanups. That document also includes numerous suggestions for scoping issues including documentation coding standards cleanups.

Contributing to the overall plan above will help ensure that your fixes for core's coding standards remain in core the long term.