Acc. to this change record, '#collapsed' should be changed to '#open'.

CommentFileSizeAuthor
#17 drupal-core-replace-collapsed-2806179-5.patch564 byteststoeckler
#14 2806179_14.patch591 byteslomasr
#8 interdiff.txt300 bytesamit.drupal
#8 drupal-core-replace-collapsed-2806179-5.patch564 bytesamit.drupal
#4 drupal-core-replace-collapsed-2806179-4-8.3.x.patch591 bytesaditya.n
#2 drupal-core-replace-collapsed-2806179-2-8.3.x.patch590 bytesaditya.n

Comments

androiditya created an issue. See original summary.

aditya.n’s picture

aditya.n commented
Status: Active » Needs review
StatusFileSize
new drupal-core-replace-collapsed-2806179-2-8.3.x.patch590 bytes

Submitting patch for the same after making changes.

markdorison’s picture

markdorison
he/him
commented
Issue summary: View changes
Status: Needs review » Needs work 
+++ b/core/modules/locale/src/Form/ExportForm.php
@@ -85,7 +85,7 @@ public function buildForm(array $form, FormStateInterface $form_state) {
+        '#open' => TRUE,

Shouldn't #open be set to FALSE to preserve the existing functionality, or is the change intentional?

aditya.n’s picture

aditya.n commented
Status: Needs work » Needs review
StatusFileSize
new drupal-core-replace-collapsed-2806179-4-8.3.x.patch591 bytes

@markdorison, yes you are right, the value of #open should be FALSE by default, silly of me not to consider that, Thanks for the correction.

Submitted the latest patch with the required changes.

markdorison’s picture

markdorison
he/him
commented
Status: Needs review » Reviewed & tested by the community

Patch works as expected.

amit.drupal’s picture

amit.drupal commented

#4 Patch is working fine.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Reviewed & tested by the community » Needs work

Since '#open' => FALSE is the default value, I think it makes more sense to simply remove the line altogether.

amit.drupal’s picture

amit.drupal commented
StatusFileSize
new drupal-core-replace-collapsed-2806179-5.patch564 bytes
new interdiff.txt300 bytes

@tstoeckler You are right .
Default value of '#collapsed' => TRUE and '#open' => FALSE.
so remove this line in code.
submit patch please review it.

amit.drupal’s picture

amit.drupal commented
Status: Needs work » Needs review
markdorison’s picture

markdorison
he/him
commented
Status: Needs review » Reviewed & tested by the community

Patch applies cleanly and works as expected.

cilefen’s picture

cilefen commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs title update

Let's please fix the issue title so this makes sense in the commit log.

markdorison’s picture

markdorison
he/him
commented
Title: Replace #collapsed with #open » Remove outdated #collapsed Form API property
Status: Needs work » Needs review
Issue tags: -Needs title update
cilefen’s picture

cilefen commented

@markdorison: You can put it back to RTBC if you think it is.

lomasr’s picture

lomasr commented
StatusFileSize
new 2806179_14.patch591 bytes

As per https://www.drupal.org/node/2204131 . Replacing '#collapsed' with '#open'.

lomasr’s picture

lomasr commented

Similar issue https://www.drupal.org/node/2806279 .

markdorison’s picture

markdorison
he/him
commented
Status: Needs review » Reviewed & tested by the community

@lomasr: We reviewed and evolved an identical patch in #4 through #8. Patch in #8 is RTBC.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
StatusFileSize
new drupal-core-replace-collapsed-2806179-5.patch564 bytes

Re-uploading patch from #8 so that it's the latest.

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Remove outdated #collapsed Form API property » Remove dead code with #collapsed Form API property

Clarifying title to make it clear that we are not making a BC break, just removing dead code.

  • xjm committed fb65cd2 on 8.3.x 
    Issue #2806179 by androiditya, amit.drupal, tstoeckler, lomasr,...
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

I confirmed that there are no other remaining references to or usages of this property:

[drupal | Sun 12:43:56] $ grep -r "\#collapsed" *
core/modules/locale/src/Form/ExportForm.php:        '#collapsed' => TRUE,

Committed fb65cd2 and pushed to 8.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.