Problem/Motivation

As we use drupal_coverage as the name of the distribution, we need to change the name of the module.

Proposed resolution

Rename the module to drupal_coverage_core

CommentFileSizeAuthor
#15 interdiff-2804825-13-15.txt714 bytesbramdriesen
#15 edit_rename_the_module-2804825-15.patch2.38 KBbramdriesen
#13 edit_rename_the_module-2804825-13.patch1.69 KBbramdriesen
#7 tree.png98.43 KBjonathan1055

Comments

legovaer created an issue. See original summary.

legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented

Renamed the module in the commit above. Awaiting with closing the issue in order to make sure that everything is still working.

jonathan1055’s picture

jonathan1055 commented

Hi Levi,
Are you sure that having the word 'core' in the module is the best idea? To all drupal devs and admins (who will be the users of this module) 'core' means a whole lot more. Do you mean that this is the 'base' module from which others build on? But having just looked at the project front pages of drupal_coverage_core and drupal_coverage maybe the 'core' module is not the base.

It is probably my understanding that is lacking ... but just thought it worth mentioning the confusion here.

Great work though - I am watching with interest :-)

Jonathan

legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented

Hi Jonathan,

Nice to see you here as well ;-)

Well.. I had some doubts about the module name indeed. But then I had a look at other distributions and it seems that a lot of them are using the same name for their "base" module.

This module is the heart/core of the distribution.. I'm still working on the documentation for both the project pages..

Feel free to have a look now & then. We're progressing very well with this project!

jonathan1055’s picture

jonathan1055 commented
StatusFileSize
new tree.png98.43 KB

OK. But can I also ask why do you have Drupal in the title? Isn't that word superfluous, and wouldn't 'Code Coverage' be more descriptive of what it actually does?

Also I noticed that when you renamed the files, you duplicated drupal_coverage_core.routing.yml by initially having the '_core' in the wrong place, as there is also a file drupal_coverage.routing_core.yml. Same for services.
files
Just thought to mention it, as currently the files are identical so better to remove the wrong ones now, before one gets editted (or the wrong one gets editted).

legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented

Jonathan,

We have decided to go for the name "Drupal Coverage" as this project will be hosted on an external website. When someone reaches the website, it should be easy to identify that this project is dedicated to Drupal.

Thanks for spotting the faulty changes! Feel free to change them yourselves if you want to help ;-)

jonathan1055’s picture

jonathan1055 commented

OK, I understand now. I can see that 'Drupal' is needed.

legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Version: » 8.x-1.x-dev
Status: Active » Needs work
legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Status: Needs work » Fixed
jonathan1055’s picture

jonathan1055 commented
Status: Fixed » Needs work

I think you switched this to 'needs work' due to the extra unwanted files I noticed in #7. Those are still there in the code repository I can see on D.O. I do not have the means to delete them so can't help yet. Maybe you forgot the files were still there and set the issue to fixed.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Assigned: Unassigned » bramdriesen
StatusFileSize
new edit_rename_the_module-2804825-13.patch1.69 KB

Removed duplicate files and also renamed the libraries file while at it.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
StatusFileSize
new edit_rename_the_module-2804825-15.patch2.38 KB
new interdiff-2804825-13-15.txt714 bytes

Rename also impacted the include of the library. Noticed I did it wrong in issue #2811481: Extract CSS from twig files so I corrected it here, the structure of the include should be like following:

'your_module/library_name'

So I corrected it this time. See latest patch and interdiff.

legovaer’s picture

legovaer
he/him
Primary language Dutch
Location Duffel
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.