Require Drupal coding standards fixes.

CommentFileSizeAuthor
#10 interdiff-2803749-7-10.txt5.93 KBminakshiPh
#10 fix-drupal-coding-std-2803749-10.patch7.46 KBminakshiPh
#7 fix-coding-std-issue-2803749-7.patch10.75 KBminakshiPh
#2 fix-coding-std-2803749-2.patch7.58 KBminakshiPh

Comments

minakshiPh created an issue. See original summary.

minakshiPh’s picture

minakshiPh commented
StatusFileSize
new fix-coding-std-2803749-2.patch7.58 KB

Added patch with fixes

Kindly review.
Thanks!

minakshiPh’s picture

minakshiPh commented
Assigned: minakshiPh » Unassigned
Status: Active » Needs review
mslabba_zyxware’s picture

mslabba_zyxware commented
Status: Needs review » Needs work

Hi @minakshiPh,
Thanks for patch.

However, we have found some issues, that you might have missed. It seems that you have used 'tabs' instead of 2 spaces.
It is found that you have removed some lines of code from zt_megamenu.module, line number starting from 9 to 17.

It would be of great if you could rectify these issues, and upload a new patch.

Drupal Coding Standards on indentation
https://www.drupal.org/docs/develop/standards/coding-standards#indenting

minakshiPh’s picture

minakshiPh commented
Assigned: Unassigned » minakshiPh
minakshiPh’s picture

minakshiPh commented

Thanks for reviewing my patch !

I'll work on the mentioned points and will provide a new patch.

minakshiPh’s picture

minakshiPh commented
Assigned: minakshiPh » Unassigned
Status: Needs work » Needs review
StatusFileSize
new fix-coding-std-issue-2803749-7.patch10.75 KB

Hi @mslabba_zyxware,

Added the new patch with fix as mentioned in #4.

Let me know if you find any issues with it.

Kindly review.
Thanks!

premshankar’s picture

premshankar
Primary language English
commented
Status: Needs review » Needs work

Hello minakshiPh,

Thanks for patch. We had tried to apply your patch, but it failed. We found that our latest patch had some changes in the scss file. So it would be of great if you consider this change, and upload a new patch.

minakshiPh’s picture

minakshiPh commented
Assigned: Unassigned » minakshiPh

Hi premshankar,

Thanks for reviewing my patch.. I'll surely work on your mentioned modifications and will upload the new patch asap.

minakshiPh’s picture

minakshiPh commented
Assigned: minakshiPh » Unassigned
Status: Needs work » Needs review
StatusFileSize
new fix-drupal-coding-std-2803749-10.patch7.46 KB
new interdiff-2803749-7-10.txt5.93 KB

Fixed mentioned changes #8 in the new patch.

Kindly review.
Thanks!

binnythomas’s picture

binnythomas commented
Status: Needs review » Reviewed & tested by the community

zyxware’s picture

zyxware commented
Status: Reviewed & tested by the community » Fixed
zyxware’s picture

zyxware commented
Status: Fixed » Closed (fixed)