Problem/Motivation

Usecase:

For some better UX we want to hide the default image by default, and just show actual uploaded images. This allows us to drop the edit/delete buttons on single value items,
which are really pointless for default images.

Proposed resolution

In order to solve that in a nice way it would be nice if the entire logic to determine the uploaded entities would be its own "small" method.
That itself makes the code a bit easier to understand/follow.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 interdiff.txt793 bytesdawehner
#5 2802969-5.patch7.82 KBdawehner
#2 2802969-2.patch7.79 KBdawehner

Comments

dawehner created an issue. See original summary.

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new 2802969-2.patch7.79 KB

Here is some code for that

Status: Needs review » Needs work

The last submitted patch, 2: 2802969-2.patch, failed testing.

The last submitted patch, 2: 2802969-2.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new 2802969-5.patch7.82 KB
new interdiff.txt793 bytes

Let's see whether this small chage fixes that :)

  • slashrsm committed a87349a on 8.x-1.x authored by dawehner 
    Issue #2802969 by dawehner: Move entity loading logic from \Drupal\...
slashrsm’s picture

slashrsm commented
Status: Needs review » Fixed
Issue tags: +D8Media

Makes sense. Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.