Comments

shruti1803 created an issue. See original summary.

shruti1803’s picture

Assigned: Unassigned » shruti1803
shruti1803’s picture

Assigned: shruti1803 » Unassigned
Status: Active » Needs review
StatusFileSize
new963 bytes

Added patch.

Status: Needs review » Needs work

The last submitted patch, 3: hook_help-2802757-3.patch, failed testing.

chishah92’s picture

Assigned: Unassigned » chishah92
chishah92’s picture

Status: Needs work » Needs review

Added patch again

~Chirag

chishah92’s picture

StatusFileSize
new963 bytes

Status: Needs review » Needs work

The last submitted patch, 7: hook_help-2802757-7.patch, failed testing.

chishah92’s picture

Status: Needs work » Needs review

The second test got passed

~Chirag

shruti1803’s picture

Assigned: chishah92 » Unassigned
StatusFileSize
new1.03 KB
damienmckenna’s picture

Status: Needs review » Needs work

Needs to be rerolled.

lomasr’s picture

StatusFileSize
new932 bytes

Here is the reroll patch. Please review.

lomasr’s picture

Status: Needs work » Needs review
damienmckenna’s picture

Component: Code » Documentation
Status: Needs review » Needs work

The D7 help message is not relevant for the D8 branch, and there isn't a main settings page to show this on either.

lomasr’s picture

StatusFileSize
new918 bytes

Sorry about that. Here is the right text. Please review.

lomasr’s picture

Status: Needs work » Needs review
damienmckenna’s picture

Status: Needs review » Needs work

This still needs improvement, it needs to describe how to use the module instead of just duplicating information from the info file.

lomasr’s picture

StatusFileSize
new898 bytes

Adding a new patch.Please review.

lomasr’s picture

Status: Needs work » Needs review
damienmckenna’s picture

Status: Needs review » Postponed
Parent issue: » #2838104: Plan for Panelizer 8.x-3.0 release

There are some internal changes going on at the moment (yay EclipseGc, mortenson, timplunkett et al!), lets wait until we're closer to having the features tied down before putting in any documentation.

damienmckenna’s picture

Status: Postponed » Needs work

Lets expand this to actually document how to use the module rather than being a placeholder.

hazong’s picture

Assigned: Unassigned » hazong
damienmckenna’s picture

Assigned: hazong » Unassigned

Unassigning this issue as it has been roughly two weeks without any further progress.

@hazong: if you do have some improvements to show, please upload what you have and we can expand upon it. Thanks!

damienmckenna’s picture

anshuljain2k8’s picture

StatusFileSize
new2.25 KB

Hi,

Added detailed help info in hook, please review.

anshuljain2k8’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 25: panelizer-hook_help-2802757-25.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

anshuljain2k8’s picture

StatusFileSize
new3.3 KB

Fixing above codesniffer fixes

anshuljain2k8’s picture

Status: Needs work » Needs review
anshuljain2k8’s picture

Version: 8.x-3.x-dev » 8.x-4.x-dev
Component: Documentation » Code
Assigned: Unassigned » anshuljain2k8
Priority: Minor » Normal
anshuljain2k8’s picture

Hi @DamienMcKenna

Is this description fine?

Thanks
Anshul

anshuljain2k8’s picture

StatusFileSize
new3.3 KB

Attaching Patch

anshuljain2k8’s picture

Priority: Normal » Major
damienmckenna’s picture

Assigned: anshuljain2k8 » Unassigned
dhruveshdtripathi’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new35.72 KB
new110.93 KB

I feel patch #32 is OK according to Help Text Standards. So changing status to RTBC.

Screenshots attached. PFA.

Thank you.

anshuljain2k8’s picture

Thanks @dhruveshdtripathi

anshuljain2k8’s picture

Can we commit this @DamienMcKenna / @dhruveshdtripathi ?

anshuljain2k8’s picture

Priority: Major » Critical
damienmckenna’s picture

Priority: Critical » Normal

Please do not mark issues as "critical" that do not either break sites entirely or lead to data loss.

anshuljain2k8’s picture

@DamienMcKenna - Are you planning to commit my patch #32

Thanks