Reviewed & tested by the community
Project:
Panelizer (obsolete)
Version:
8.x-4.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
20 Sep 2016 at 06:30 UTC
Updated:
19 Jul 2018 at 04:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
shruti1803 commentedComment #3
shruti1803 commentedAdded patch.
Comment #5
chishah92 commentedComment #6
chishah92 commentedAdded patch again
~Chirag
Comment #7
chishah92 commentedComment #9
chishah92 commentedThe second test got passed
~Chirag
Comment #10
shruti1803 commentedComment #11
damienmckennaNeeds to be rerolled.
Comment #12
lomasr commentedHere is the reroll patch. Please review.
Comment #13
lomasr commentedComment #14
damienmckennaThe D7 help message is not relevant for the D8 branch, and there isn't a main settings page to show this on either.
Comment #15
lomasr commentedSorry about that. Here is the right text. Please review.
Comment #16
lomasr commentedComment #17
damienmckennaThis still needs improvement, it needs to describe how to use the module instead of just duplicating information from the info file.
Comment #18
lomasr commentedAdding a new patch.Please review.
Comment #19
lomasr commentedComment #20
damienmckennaThere are some internal changes going on at the moment (yay EclipseGc, mortenson, timplunkett et al!), lets wait until we're closer to having the features tied down before putting in any documentation.
Comment #21
damienmckennaLets expand this to actually document how to use the module rather than being a placeholder.
Comment #22
hazong commentedComment #23
damienmckennaUnassigning this issue as it has been roughly two weeks without any further progress.
@hazong: if you do have some improvements to show, please upload what you have and we can expand upon it. Thanks!
Comment #24
damienmckennaComment #25
anshuljain2k8 commentedHi,
Added detailed help info in hook, please review.
Comment #26
anshuljain2k8 commentedComment #28
anshuljain2k8 commentedFixing above codesniffer fixes
Comment #29
anshuljain2k8 commentedComment #30
anshuljain2k8 commentedComment #31
anshuljain2k8 commentedHi @DamienMcKenna
Is this description fine?
Thanks
Anshul
Comment #32
anshuljain2k8 commentedAttaching Patch
Comment #33
anshuljain2k8 commentedComment #34
damienmckennaComment #35
dhruveshdtripathi commentedI feel patch #32 is OK according to Help Text Standards. So changing status to RTBC.
Screenshots attached. PFA.
Thank you.
Comment #36
anshuljain2k8 commentedThanks @dhruveshdtripathi
Comment #37
anshuljain2k8 commentedCan we commit this @DamienMcKenna / @dhruveshdtripathi ?
Comment #38
anshuljain2k8 commentedComment #39
damienmckennaPlease do not mark issues as "critical" that do not either break sites entirely or lead to data loss.
Comment #40
anshuljain2k8 commented@DamienMcKenna - Are you planning to commit my patch #32
Thanks