Translations inside classes should be like "$this->t('')" and not t('') only;

CommentFileSizeAuthor
#5 Translations_v2-2800381-5.patch1.73 KBkunalkursija
#2 Translations-2800381-2.patch1.72 KBkunalkursija

Comments

kunal.kursija created an issue. See original summary.

kunalkursija’s picture

kunalkursija commented
StatusFileSize
new Translations-2800381-2.patch1.72 KB

Attaching patch.

kunalkursija’s picture

kunalkursija commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: Translations-2800381-2.patch, failed testing.

kunalkursija’s picture

kunalkursija commented
Status: Needs work » Needs review
StatusFileSize
new Translations_v2-2800381-5.patch1.73 KB

Attaching patch again.

dishabhadra’s picture

dishabhadra commented
Status: Needs review » Reviewed & tested by the community

It's good to replace t() with $this->t().

matrixlord’s picture

matrixlord commented

Hello,

Thanks! This already exists in the dev version. I will push it to a stable release with some other fixes soon.

matrixlord’s picture

matrixlord commented
Status: Reviewed & tested by the community » Fixed

matrixlord’s picture

matrixlord commented

P.S. I will give the attribution to kunal.kursija of course.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.