Webform API number field min max values not validating [#2799691]

Hi,

When creating a Numeric field via Webform API, Min and Max values are not validated.

$form['access_required']['new_desk'] = array(
'#type' => 'webform_number',
'#title' => t('Desk Number'),
'#required' => 1,
'#attributes' => array(
'min' => '10',
'max' => '100',
'class' => array(
'numeric'
),
),
);

In the above example, even if I type -5 as the value, no error messages are shown. However, required attribute is validating correctly.

Thanks

Comment	File	Size	Author
#3	before.png	9.38 KB	Dev1.addweb
#3	after.png	17.16 KB	Dev1.addweb
#3	edit_webform_api_number-2799691-1.patch	552 bytes	Dev1.addweb

Comments

Comment #1

14 September 2016 at 05:48

crystalgrafix created an issue. See original summary.

Comment #2

tannguyenhn commented 14 September 2016 at 07:11

crystalgrafix
Are you implementing a hook form alter or hook form ?

Comment #3

Dev1.addweb commented 14 September 2016 at 07:19

Status:

Active

» Needs review

Status	File	Size
new	edit_webform_api_number-2799691-1.patch	552 bytes
new	after.png	17.16 KB
new	before.png	9.38 KB

Apply following patch to make things work. Please note it will not support comma separated or decimal numbers. Let me know in case of any concerns.

Thanks

Comment #4

crystalgrafix commented 14 September 2016 at 08:20

Thanks Deepali! Your patch is doing the trick.

Comment #5

Dev1.addweb commented 14 September 2016 at 10:48

Status:

Needs review

» Reviewed & tested by the community

Thanks crystalgrafix! Happy to know that efforts I put in to resolved the issue worked for you.

Would be awaiting for credit on this :)

Comment #6

quicksketch

he/him

commented 28 September 2016 at 20:05

Status:

Reviewed & tested by the community

» Needs work

Hi @Deepali_Argawal, we specifically disabled the use of a "number" input field per the code comments directly above that line. See #2290029: Thousands separator creates invalid value for HTML5 Number input and #2202905: Decimal numbers with comma as placeholder fail validation in Chrome. We will need to validate that those problems do not exist, otherwise we'll just be trading one set of problems for another.

In any case, if we apply this change, we should at least update the code comments.