Right now we always show "Save" and "Save and make default". The latter button doesn't make sense when the profile type does not support multiple profiles, nor when it is the first profile of the type if multiple are supported.

CommentFileSizeAuthor
#12 only_show_save-2799669-12.patch4.71 KBmglaman
#9 only_show_save-2799669-9.patch3.82 KBmglaman
#3 only_show_save-2799669-3.patch3.87 KBmglaman
Create_Billing___Site-Install.png127.39 KBmglaman

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Issue summary: View changes
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs review
StatusFileSize
new only_show_save-2799669-3.patch3.87 KB

Only shows "Save" when the profile is new, or multiple is not supported (and sets default.) When multiple supported, shows "Save and make default" when there is an existing profile and the current (if edit) is not default.

Status: Needs review » Needs work

The last submitted patch, 3: only_show_save-2799669-3.patch, failed testing.

The last submitted patch, 3: only_show_save-2799669-3.patch, failed testing.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review

Test runner borked out.

Status: Needs review » Needs work

The last submitted patch, 3: only_show_save-2799669-3.patch, failed testing.

The last submitted patch, 3: only_show_save-2799669-3.patch, failed testing.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review
StatusFileSize
new only_show_save-2799669-9.patch3.82 KB

Oops, forgot a var_dump from debug. Maybe that's why?

Status: Needs review » Needs work

The last submitted patch, 9: only_show_save-2799669-9.patch, failed testing.

The last submitted patch, 9: only_show_save-2799669-9.patch, failed testing.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review
StatusFileSize
new only_show_save-2799669-12.patch4.71 KB

Fix last test

  • mglaman committed ef9fb4b on 8.x-1.x 
    Issue #2799669 by mglaman: Only show "Save" instead of both buttons when...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.