Closed (fixed)
Project:
Commerce Core
Version:
8.x-2.x-dev
Component:
User experience
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
13 Sep 2016 at 21:42 UTC
Updated:
20 Oct 2016 at 15:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mglamanShould we create a shared base for this and attribute selector? That way the AJAX callback doesn't need to be duplicated.
Comment #3
bojanz commentedI like the general idea of adding a widget for this.
@mglaman
Maybe we create an AjaxRefreshTrait and put the method there?
You would map label_display = FALSE to #title_display => 'invisible'.
Not sure these defaults make sense. To start with, the label should not have ':'. Maybe we go with label_display => FALSE and "Please select" as the label? Open to ideas
Comment #4
steveoliver commentedmglaman, bojanz, all good suggestions. Addressed them in attached patch.
Comment #5
steveoliver commentedWoops, missed "You would map label_display = FALSE to #title_display => 'invisible'." ... coming up.
Comment #6
steveoliver commentedComment #7
steveoliver commentedComment #8
steveoliver commentedComment #10
bojanz commentedConverted the trait to a base field after some deliberations. Added missing schema.
Committed, thanks!