Roles on a profile type just control the access handler. We can convert tthis to a kernel test

CommentFileSizeAuthor
#12 refactor_and_improve-2799579-12.patch48.87 KBmglaman
#9 refactor_and_improve-2799579-9.patch46.12 KBmglaman
#6 convert-2799579-6.patch19.71 KBmglaman
#2 convert-2799579-2.patch10.91 KBmglaman

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs review
StatusFileSize
new convert-2799579-2.patch10.91 KB

Patch.

Status: Needs review » Needs work

The last submitted patch, 2: convert-2799579-2.patch, failed testing.

The last submitted patch, 2: convert-2799579-2.patch, failed testing.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

This shows how broken \Drupal\profile\ProfileAccessControlHandler is. I'll work to get it fixed up.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Title: Convert ProfileRoleAccessTest to kernel test » Refactor and improve ProfileAccessControlHandler
Status: Needs work » Needs review
StatusFileSize
new convert-2799579-6.patch19.71 KB

Here is a patch which fixes up ProfileAccessControlHandler and does tests. This is much cleaner and will fix other issues in the queue.

Status: Needs review » Needs work

The last submitted patch, 6: convert-2799579-6.patch, failed testing.

The last submitted patch, 6: convert-2799579-6.patch, failed testing.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review
StatusFileSize
new refactor_and_improve-2799579-9.patch46.12 KB

Still failing. Ported rest of tests to functional tests.

Status: Needs review » Needs work

The last submitted patch, 9: refactor_and_improve-2799579-9.patch, failed testing.

The last submitted patch, 9: refactor_and_improve-2799579-9.patch, failed testing.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review
StatusFileSize
new refactor_and_improve-2799579-12.patch48.87 KB

Tests passing locally! Problem was \Drupal\profile\Access\ProfileAccessCheck

  • mglaman committed d97a38c on 8.x-1.x 
    Issue #2799579 by mglaman: Refactor and improve...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.