There have been some minor changes to the GCWeb theme:

http://wet-boew.github.io/themes-dist/GCWeb/home-en.html

CommentFileSizeAuthor
#2 update_to_gcweb_footer-2799287-2.patch9.61 KBsylus
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sylus created an issue. See original summary.

sylus’s picture

sylus CreditAttribution: sylus commented
FileSize
update_to_gcweb_footer-2799287-2.patch9.61 KB

Alright I have attached a patch that does a few things:

a) Alter the panels--page--gcweb.tpl.php + page--gcweb.tpl.php to the new markup:
i) Add new menu region that exists in other themes print $page['menu_terms_bar']; (this will be the new bottom footer for gcweb)
b) wetkit_bootstrap_menu_link__menu_block__mid_footer_menu has been modified to keep existing logic for all themes except for gcweb which has had it logic adjusted to adhere to new markup + flat structure of list items.

So in the end with this patch the markup is aligned to output correctly but the links will need to be manually changed to reflect modified gcweb links which can simply be done through UI.

sylus’s picture

sylus CreditAttribution: sylus commented
Status: Active » Needs review

  • sylus authored 530009d on 7.x-4.x 
    Merge pull request #1884 from sylus/7.x-4.x

Fixed WetKit Bootstrap for...
  • sylus committed 7b1cb9c on 7.x-4.x
    Fixed WetKit Bootstrap for Issue #2799287: Update to gcweb footer
sylus’s picture

sylus CreditAttribution: sylus commented
Status: Needs review » Fixed
lampson’s picture

lampson CreditAttribution: lampson commented

I have tested this and it works but I had to add the same footer markup to our bootstrap theme (page and panel tpl files) as we override wetkit_bootstrap. The menu "menu-wet-terms" gets reused which is nice so no additional menus need to be created. This change will match wet 4.0.22-stable (http://wet-boew.github.io/wet-boew/docs/versions/dwnld-en.html#v40stable). Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

sylus’s picture

sylus CreditAttribution: sylus commented

I have added additional migrate config that is gcweb specific so if a user is currently using the gcweb variant as active theme, the migration for WetKitMigrateSiteMenu will switch to the gcweb links instead of the default. Here is the logic which affects the xpath selector againt the migrate_site_menu.xml under wetkit_migrate.

    // Custom Logic Based on Theme Selection (Internet, Intranet or Base).
    $wxt_active = variable_get('wetkit_wetboew_theme', 'theme-wet-boew');
    if ($wxt_active == 'theme-gcweb') {
      $item_xpath = '/menu_handler/menu_links/*/section[@variant="gcweb"]';
    }
    else {
      $item_xpath = '/menu_handler/menu_links/*/section[not(@variant="gcweb")]';
    }

Then a simple drush mi WetKitMigrateSiteMenuLinks will add the new menu links.

Commit is here:

http://cgit.drupalcode.org/wetkit_migrate/commit/?id=62436d75c226c6b919d...

Please don't forget to clear the WxT specific render caches as well afterwards @ admin/config/development/performance