From #2725247: Review gateway plugins, sort out what to do with \Drupal\sms\Plugin\SmsGatewayPluginInterface::getDeliveryReports(). It is not used by SMS Framework nor does it have test coverage.

Add annotation to gateway:

  • gateway_reports_pull: boolean
    Whether the gateway plugin can pull reports from the gateway.
  • gateway_reports_pushed: boolean
    Whether the gateway plugin can handle reports pushed from the gateway.

Where can we use this pull method in SMS framework?

  • Provide a future UI to force pull.
  • Use Drupal cron to automate these.
CommentFileSizeAuthor
#4 gateway-plugin-pull-delivery-reports-2798163-4-a707788.patch14.57 KBdpi
#3 gateway-plugin-pull-delivery-reports-2798163-3-e652ebd.patch16.15 KBdpi
#2 gateway-plugin-pull-delivery-reports-2798163.patch15.65 KBdpi

Comments

dpi created an issue. See original summary.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Active » Needs review
StatusFileSize
new gateway-plugin-pull-delivery-reports-2798163.patch15.65 KB

https://github.com/dpi/smsframework/pull/54

Changes

  • Added 'reports_pull' and 'reports_push' annotation to gateway plugin.
  • Added annotation definition getters to gateway entity, for each of pull and push: supportsReportsPull and supportsReportsPush (added tests for this).
  • The pushed route will now be disabled if the plugin does not support pushed reports
    • (added tests for this)
    • added infrastructure to support this: SupportsPushedReportsAccessCheck
  • The pushed reports path will no longer show on the gateway form if it is not supported. (added tests for this)
  • Updated documentation of Gateway::getDeliveryReports. The signature and return of the method have not changed.
  • There is duplicated code from #2798161: Gateway plugin balance query to support the "capabilities_default" testing gateway.
dpi’s picture

dpi
Location Perth, Australia
commented
StatusFileSize
new gateway-plugin-pull-delivery-reports-2798163-3-e652ebd.patch16.15 KB

Updated access checks to use anon.

dpi’s picture

dpi
Location Perth, Australia
commented
StatusFileSize
new gateway-plugin-pull-delivery-reports-2798163-4-a707788.patch14.57 KB

Re-checking after many merge conflicts with #2798161: Gateway plugin balance query and HEAD.

  • dpi committed b0bcf49 on 8.x-1.x 
    Issue #2798163 by dpi: Gateway plugin delivery reports capabilities

Status: Needs review » Needs work

The last submitted patch, 4: gateway-plugin-pull-delivery-reports-2798163-4-a707788.patch, failed testing.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.