Hello,

I was testing Drupal commerce and on the review page I saw that a bootstrap panel with a link inside and the link was not rendered. See the attached screenshots.

I will upload a quick fix.

If there is a more generic way to handle it, feel free to tell me and I will rework the patch.

CommentFileSizeAuthor
#4 bootstrap-html_bootstrap_panel_header-2797007-4.patch1.38 KBgrimreaper
#2 bootstrap-link_bootstrap_panel-2797007-2.patch1.02 KBgrimreaper
bootstrap_fieldset_title_escaped_bootstrap_after.png7.29 KBgrimreaper
bootstrap_fieldset_title_escaped_bootstrap_before.png9.39 KBgrimreaper
bootstrap_fieldset_title_escaped_bartik.png4.96 KBgrimreaper

Comments

Grimreaper created an issue. See original summary.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Active » Needs review
StatusFileSize
new bootstrap-link_bootstrap_panel-2797007-2.patch1.02 KB

Here is the patch.

Thanks for the review.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Title: Link not rendered in bootstrap panel » HTML is not rendered in panel header
Status: Needs review » Needs work

It should only be wrapped in #markup if the header value is a string or an instance of MarkupInterface, otherwise it could be a render array. Also, please use the shorthand array.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs work » Needs review
StatusFileSize
new bootstrap-html_bootstrap_panel_header-2797007-4.patch1.38 KB

Hello,

Thanks for the review. Here is a new patch.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.