Price not updated for variations when products shown in list views

It sounds like some cache tags are not properly being invalidated when the variation is changed. The bug might be that it's not clearing the Views cache? Either way some cache tag isn't being invalidated somewhere.

So, unfortunately it can be difficult. I'm not even sure how I'd debug it right now without going all out with xdebug.

The first thing is to check the ProducrVariation entity class. We should be adding the Product it belongs to cache tags to its invalidate cache tags call. Maybe even experiment with adding more stuff there, no idea.

It's either Views render cache, which should invalidate with entity save. Or the variation isn't actually invalidating the Products view cache.

So if you're new to D8s render cache and cache tag/context system, this is one hell of an intro/dive in issue.

I say don't be afraid and try it out :) you'll want to have it in your back pocket.

Next steps though is writing a test to verify this bug.

Okay, I guess it's time to create a test view and really get a test going for this. I assume that dynamic page cache and page cache are enabled. Is this for authenticated and anonymous users?

The add to cart problem sounds familiar. I had a similar problem when I implemented and add to cart button directly for a variation view instead of the default one for product entities. When I used that to show 4 variations in a list,I had the same problem and I solved it

Unfortunately I don't have access to that repo atm before Sunday... I'm not sure but AFAIK it had to do with the form ID or similar

krabbe, is that view generic enough you could paste the config YML here? Or possible send if in a PM? We need to make a test using a sample View, but need to make sure I built one properly.

I confirm the issue. Only the first product in a block-view works as expected. The others don't change their values (Title, SKU, Price) being chosen. Well, actually they change them but only on the the very first product, not on itself.

See the exported YML of the view.

drugan, thanks!

CommerceAddToCartForm must provide an unique form ID. That's why always the same product is added to cart.

My quick and not too sexy workaround was to use a static counter variable and add this to the form ID

In 1.x we made it based on the product's ID (well, variations actually.) I'll write a test which imports this view and does all those things. Sitting down with it now.

This looks surprisingly simple.

Based on

    $form_id = $this->entity->getEntityTypeId();
    if ($this->entity->getEntityType()->hasKey('bundle')) {
      $form_id .= '_' . $this->entity->bundle();
    }
    if ($this->operation != 'default') {
      $form_id = $form_id . '_' . $this->operation;
    }
    return $form_id . '_form';

We just need a unique operation.

diff --git a/modules/product/src/ProductLazyBuilders.php b/modules/product/src/ProductLazyBuilders.php
index c14dd01..3cb1171 100644
--- a/modules/product/src/ProductLazyBuilders.php
+++ b/modules/product/src/ProductLazyBuilders.php
@@ -73,7 +73,7 @@ class ProductLazyBuilders {
         'combine' => $combine,
       ],
     ];
-    return $this->entityFormBuilder->getForm($line_item, 'add_to_cart', $form_state_additions);
+    return $this->entityFormBuilder->getForm($line_item, 'add_to_cart_' . $product_id, $form_state_additions);
   }

Can you try the patch? We still need tests

Here we go! Fix with test. PR here: https://github.com/drupalcommerce/commerce/pull/487

Test is not a FunctionalJavascript test for attribute changing. Merely that with 5 add to cart forms, clicking submit on third adds proper product. We can extend to test FunctionalJavascript if needed.

For me also #18 works. Thank you!

Thanks,

works for me.
also #18 fix https://www.drupal.org/node/2786245

Shouldn't we include the operation in getBaseFormId() as well?

If you want to target all add to cart forms in a hook_form_BASE_FORM_ID_alter(), this would be much more convenient...

Updated base form ID: commerce_line_item_add_to_cart_form. Then a form ID would be like commerce_line_item_product_variation_add_to_cart_PRODUCTID_form.

Tests still stupid on Travis.

Attributing this work to ThinkBean.

Updated PR to change view name and route to match "test multiple carts". Should be merged if tests still pass with change.

Thanks everyone for confirming! Merged.