In PHP 7 onwards, primitives can be used as type hints as well as class names and array, callable. For example:
public function sliceCheese(int $slices, string $cheeseType) : string {
// Implementation.
}
Currently coder sniffer doesn't appear to support these types as hints.
I have attached a patch that is very basic but does allow for this. It's probably going to need a bit of cleaning up though, because this isn't the best way of implementing this, but it's hard for me without detailed knowledge of the sniffer code.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 2795149-add-primitive-types-3.patch | 2.05 KB | chriscohen |
| #2 | 2795149-add-primitive-types.patch | 1.23 KB | chriscohen |
Comments
Comment #2
chriscohen commentedComment #3
chriscohen commentedSorry, noticed a bug in that the previous patch REQUIRED you to put the primitive type hint in place. This patch makes that optional but permissible.
Comment #4
klausiMakes sense! Can you file a pull request against https://github.com/klausi/coder so that we see tests and coding standards are passing?
You can also look at upstream https://github.com/squizlabs/PHP_CodeSniffer/blob/master/CodeSniffer/Sta... because they also take care of 'integer' for example. I don't like the PHP version check, so we can ignore that.
Can you also add an example test function to good.php?
Comment #5
chriscohen commentedI really am truly sorry but my workload does not permit me to continue work on this issue: I felt it was important to report it and I filed what code I have, so hopefully this will be enough to get started on a fix here?
Comment #7
klausiChanged the patch a bit and added a test. Thanks for reporting!