Add assertNoCacheTag to assertLegacyTrait

The method assertCacheContexts contains a call togetCacheHeaderValues() which on his side contains a call to WebTestBase::drupalGetHeader().

I think we first need to identify how we're going to provide exactly the same functionality within PHPUnit before we can start working on this issue.

I would like to work on this issue. This would be my first task with drupal, so I might need some help.

This is needed by a lot of tests for a wtb to btb conversion

Change record has been created.

Only if every cache asserts are moving to this assertCacheTrait.

1/ We add this asserts to assertLegacyTrait and will move every cache assert in a new assertCacheTrait with another issue.
2/ First we put those asserts to a new assertCacheTrait than we will move other cache assert to assertCacheTrait with another issue.

I have no preference for one or the other.

I have encountered another test that could use it here:
#2863644: Convert web tests of block.

As there is a valid alternative in Mink I prefer adding it to the AssertLegacyTrait so we can dump them again in Drupal 9.

+1 on the needs tests though, we need to add coverage for these assertions in BrowserTestBaseTest.

Adding a tag based on #17. Maybe the attention this issue got in #17 is barely enough that I should keep the Baltimore2017 tag.

oops

Maybe better to convert AssertPageCacheContextsAndTagsTrait & deprecate in favour of new one?

Aghhh ok just wrote a different comment 3 times and then when diving in deeper turned completely around on this again and again!

I think that the title should point to assertCacheTag and assertNoCacheTag (@dawehner correct me if I'm wrong please), since these methods exist on WebTestBase, and nowhere else. So not cacheContext. The cacheContext methods are available on AssertPageCacheContextsAndTagsTrait and anything needing those should wait for #2863318: Cache: Convert system functional tests to phpunit to land. So the patch in #10 is not correct (sorry).

Updating the IS with what I think should be done here, but of course update it if I'm reading all of this wrong.

We have assertCacheTag in AssertLegacyTrait we need assertNoCacheTag, assertCacheContext/assertNoCacheContext to BTB
Updated IS accordingly.

//Naveen

Here's the patch.
This issue is blocking these issues:
- #2870452: Convert web tests to browser tests for menu_ui module
- #2870439: Convert web tests to browser tests for config module
- #2863644: Convert web tests of block

@naveenvalecha I think the interdiff in #24 is the patch as it should be. Both assertCacheContext and assertNoCacheContext are (or will be) available on \Drupal\system\Tests\Cache\AssertPageCacheContextsAndTagsTrait, that just needs to be converted. If we add those methods to AssertLegacyTrait we will be in a right mess when you use AssertPageCacheContextsAndTagsTrait once it's converted.

\Drupal\system\Tests\Cache\AssertPageCacheContextsAndTagsTrait is being used by the WTB tests. if we'll convert it for BTB then the WTB tests(which are using this Trait) will fail b/c $this->assertSession() only compatible with the BTB not WTB. So we need to add these methods to the AssertLegacyTrait for now and we rely on the AssertPageCacheContextsAndTagsTrait once all the conversion will be done.

OR

We could add a copy of AssertPageCacheContextsAndTagsTrait into BTB namespace and use it in BTB tests. What do you think?

//Naveen

We could add a copy of AssertPageCacheContextsAndTagsTrait into BTB namespace and use it in BTB tests. What do you think?

That one, and deprecate the old one, but I would consider that work part of #2863318: Cache: Convert system functional tests to phpunit. This issue just needs to worry about assertNoCacheTag since that is not available anywhere for BrowserTestBase and doesn't exist on any traits, only on WebTestBase itself

updated the IS as per #27

Here's the correct one.

Nice. Still needs some test coverage added in \Drupal\Tests\Core\Assert\AssertLegacyTraitTest

Nice one.

This is blocker for issues mentioned in IS

+++ b/core/tests/Drupal/FunctionalTests/AssertLegacyTrait.php
@@ -720,6 +720,22 @@ protected function assertCacheTag($expected_cache_tag) {
+   * @see https://www.drupal.org/node/2864029

We need to update the change record (it is about contexts not tags)

Adding @Lendude to issue credits as he was instrumental in shaping patch

Can someone provide new copy to go in the change record on commit?

Updated the change record to match the actual change.

Committed as ba0ac0f and pushed to 8.4.x. Keep up the great work!

Yay! lots of issues unblocked! thanx Lee)

Thanks a ton! Lee, it unblocked a couple of issues and will help to gain the momentum to phpunit issues.