The tests didn't get done in the initial port, and a fair number of other things as well. Although it's been functional and very useful, it's time to get the tests going and fix a few other anomalies.

Following patch makes the tests work... and in some cases restores lost functionality. It also removes cruft code and updates the README to match 8.x reality.

CommentFileSizeAuthor
#36 reroute_email.8_x_tests_and_functionality_2794777_36.patch119.23 KBrfay
#32 reroute_email.8_x_tests_and_functionality_17_5.patch119.42 KBrfay
#29 reroute_email.8_x_tests_and_functionality_17_4.patch119.35 KBrfay
#26 reroute_email.8_x_tests_and_functionality_17_3.patch118.7 KBrfay
#23 reroute_email.8_x_tests_and_functionality_17_2.patch118.81 KBrfay
#20 reroute_email.8_x_tests_and_functionality_17+getmessages.patch118.81 KBrfay
#17 reroute_email.8_x_tests_and_functionality_17.patch118.79 KBrfay
#14 reroute_email.8_x_tests_and_functionality_14.patch118.79 KBrfay
#10 reroute_email.8_x_tests_and_functionality_2794777_10.patch118.7 KBrfay
#7 reroute_email.8_x_tests_and_functionality_2794777_07.patch118.55 KBrfay
#4 reroute_email.8_x_tests_and_functionality_2794777_04.patch118.32 KBrfay
reroute_email.8_x_tests_and_functionality_01.patch118.13 KBrfay

Comments

rfay created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, reroute_email.8_x_tests_and_functionality_01.patch, failed testing.

The last submitted patch, reroute_email.8_x_tests_and_functionality_01.patch, failed testing.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs work » Needs review
StatusFileSize
new reroute_email.8_x_tests_and_functionality_2794777_04.patch118.32 KB

Fixes classic out-of-memory in print_r(); Remove $message['params'] to make the array less complex.

Status: Needs review » Needs work

The last submitted patch, 4: reroute_email.8_x_tests_and_functionality_2794777_04.patch, failed testing.

The last submitted patch, 4: reroute_email.8_x_tests_and_functionality_2794777_04.patch, failed testing.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs work » Needs review
StatusFileSize
new reroute_email.8_x_tests_and_functionality_2794777_07.patch118.55 KB

Runs fine locally, struggling to figure out what's happening. Added flood control configuration.

Status: Needs review » Needs work

The last submitted patch, 7: reroute_email.8_x_tests_and_functionality_2794777_07.patch, failed testing.

The last submitted patch, 7: reroute_email.8_x_tests_and_functionality_2794777_07.patch, failed testing.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
StatusFileSize
new reroute_email.8_x_tests_and_functionality_2794777_10.patch118.7 KB

More debugging added

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 10: reroute_email.8_x_tests_and_functionality_2794777_10.patch, failed testing.

The last submitted patch, 10: reroute_email.8_x_tests_and_functionality_2794777_10.patch, failed testing.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs work » Needs review
StatusFileSize
new reroute_email.8_x_tests_and_functionality_14.patch118.79 KB

something about drupal_set_message() ? Trying removing the dsm that is working.

Status: Needs review » Needs work

The last submitted patch, 14: reroute_email.8_x_tests_and_functionality_14.patch, failed testing.

The last submitted patch, 14: reroute_email.8_x_tests_and_functionality_14.patch, failed testing.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs work » Needs review
StatusFileSize
new reroute_email.8_x_tests_and_functionality_17.patch118.79 KB

Status: Needs review » Needs work

The last submitted patch, 17: reroute_email.8_x_tests_and_functionality_17.patch, failed testing.

The last submitted patch, 17: reroute_email.8_x_tests_and_functionality_17.patch, failed testing.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs work » Needs review
StatusFileSize
new reroute_email.8_x_tests_and_functionality_17+getmessages.patch118.81 KB

Status: Needs review » Needs work

The last submitted patch, 20: reroute_email.8_x_tests_and_functionality_17+getmessages.patch, failed testing.

The last submitted patch, 20: reroute_email.8_x_tests_and_functionality_17+getmessages.patch, failed testing.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs work » Needs review
StatusFileSize
new reroute_email.8_x_tests_and_functionality_17_2.patch118.81 KB

Status: Needs review » Needs work

The last submitted patch, 23: reroute_email.8_x_tests_and_functionality_17_2.patch, failed testing.

The last submitted patch, 23: reroute_email.8_x_tests_and_functionality_17_2.patch, failed testing.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs work » Needs review
StatusFileSize
new reroute_email.8_x_tests_and_functionality_17_3.patch118.7 KB

Status: Needs review » Needs work

The last submitted patch, 26: reroute_email.8_x_tests_and_functionality_17_3.patch, failed testing.

The last submitted patch, 26: reroute_email.8_x_tests_and_functionality_17_3.patch, failed testing.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs work » Needs review
StatusFileSize
new reroute_email.8_x_tests_and_functionality_17_4.patch119.35 KB

Status: Needs review » Needs work

The last submitted patch, 29: reroute_email.8_x_tests_and_functionality_17_4.patch, failed testing.

The last submitted patch, 29: reroute_email.8_x_tests_and_functionality_17_4.patch, failed testing.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs work » Needs review
StatusFileSize
new reroute_email.8_x_tests_and_functionality_17_5.patch119.42 KB

Status: Needs review » Needs work

The last submitted patch, 32: reroute_email.8_x_tests_and_functionality_17_5.patch, failed testing.

The last submitted patch, 32: reroute_email.8_x_tests_and_functionality_17_5.patch, failed testing.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

Oh dear, finally figured out what was different between my local and the testbot. It's Drupal 8.3.x that is the issue. The tests are totally clean on 8.2.x, which is what I had, but the testbot is now up to 8.3.x.

So now I'm trying to figure out what could possibly be wrong.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs work » Needs review
StatusFileSize
new reroute_email.8_x_tests_and_functionality_2794777_36.patch119.23 KB

The problem was a significant change in config of the contact module (allowing config of the confirmation message, which we keyed on; the default was no message.)

git bisect to the rescue. But it would have been smarter to actually look at the contact config form in later versions.

  • rfay committed cf6ac33 on 8.x-1.x 
    Issue #2794777 by rfay: reroute_email 8.x tests and fixes
rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs review » Fixed

Committed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.