Replaced \Drupal::url with Url::fromRoute.

CommentFileSizeAuthor
#8 drupal_url_is-2794313-8.patch723 bytesmglaman
#2 patch-2794313.patch1.1 KBchaitanya17

Comments

chaitanya17 created an issue. See original summary.

chaitanya17’s picture

chaitanya17 commented
Status: Active » Needs review
StatusFileSize
new patch-2794313.patch1.1 KB

Please check attached working patch

Status: Needs review » Needs work

The last submitted patch, 2: patch-2794313.patch, failed testing.

The last submitted patch, 2: patch-2794313.patch, failed testing.

chaitanya17’s picture

chaitanya17 commented
Status: Needs work » Needs review

I have tested patch on working project functionality is working properly after applying the patch.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Needs work

chaitanya17, please do not hijack statuses. The testing reports an error, rectify the error before marking for review.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

Error at hand:

13:47:39 PHP Fatal error:  Cannot use Drupal\Core\Url as Url because the name is already in use in modules/profile/src/Form/DeleteMultiple.php on line 12
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review
StatusFileSize
new drupal_url_is-2794313-8.patch723 bytes

Here is a corrected patch.

  • mglaman committed 2136769 on 8.x-1.x 
    Issue #2794313 by mglaman: \Drupal::url is deprecated
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Fixed

Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.