Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Or is there any reason to have it as "string"?
Comment | File | Size | Author |
---|---|---|---|
#8 | 2794295-8--default_index_field_tags.patch | 738 bytes | drunken monkey |
|
Comments
Comment #2
isramv CreditAttribution: isramv commentedPlease review the patch and let me know if that is the change is needed.
Comment #3
drunken monkeyYes, that's exactly what I had in mind, thanks! (Please set the status to "Needs review" when you post a patch, though.)
However, a second look at this shows why it's currently "string": we don't index the reference itself, but the referenced term's name! Not sure why we do this, maybe because it works better with facets?
Anyways, once we add #2625152: Implement a Hierarchical Entity Processor this would have the downside that we can't just enable that processor for the field – it will only work on the reference itself.
So, either we leave this as-is after all, or we change the field's property path along with the type, to point to the Tags field itself.
Sorry for not looking at this more closely when creating the issue. Still, thanks again for your help!
Comment #4
isramv CreditAttribution: isramv commentedComment #5
drunken monkeyThere is now no patch to review, so "Active" is the correct status.
Why did you assign to you? Do you want to work on this? If so, then I think the first step should be figuring out how we want to resolve this.
Comment #6
isramv CreditAttribution: isramv commentedI thought that was the process, I am not so familiar with the workflow.
Comment #7
drunken monkeyIf you want to work on a patch, then yes, assigning the issue to yourself is the correct way. However, since, as stated, there isn't yet a plan for what that patch should even do, you can't really work on a patch.
What's your opinion on how to proceed?
Comment #8
drunken monkeyAfter seven months without any comment, it seems nobody really cares strongly about this either way. I think we should go with the field itself, it should be less confusing to people.
Patch attached, please test/review!
Comment #9
alan-ps CreditAttribution: alan-ps commentedI tested it and all works fine. RTBC
Comment #11
drunken monkeyGood to hear, thanks for testing!
Committed.
Thanks again, also, to isramv!