Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drunken monkey created an issue. See original summary.

isramv’s picture

Please review the patch and let me know if that is the change is needed.

drunken monkey’s picture

Issue tags: -Novice

Yes, that's exactly what I had in mind, thanks! (Please set the status to "Needs review" when you post a patch, though.)

However, a second look at this shows why it's currently "string": we don't index the reference itself, but the referenced term's name! Not sure why we do this, maybe because it works better with facets?
Anyways, once we add #2625152: Implement a Hierarchical Entity Processor this would have the downside that we can't just enable that processor for the field – it will only work on the reference itself.

So, either we leave this as-is after all, or we change the field's property path along with the type, to point to the Tags field itself.

Sorry for not looking at this more closely when creating the issue. Still, thanks again for your help!

isramv’s picture

Assigned: Unassigned » isramv
Status: Active » Needs review
drunken monkey’s picture

Status: Needs review » Active

There is now no patch to review, so "Active" is the correct status.
Why did you assign to you? Do you want to work on this? If so, then I think the first step should be figuring out how we want to resolve this.

isramv’s picture

I thought that was the process, I am not so familiar with the workflow.

drunken monkey’s picture

If you want to work on a patch, then yes, assigning the issue to yourself is the correct way. However, since, as stated, there isn't yet a plan for what that patch should even do, you can't really work on a patch.
What's your opinion on how to proceed?

drunken monkey’s picture

After seven months without any comment, it seems nobody really cares strongly about this either way. I think we should go with the field itself, it should be less confusing to people.
Patch attached, please test/review!

alan-ps’s picture

Status: Needs review » Reviewed & tested by the community

I tested it and all works fine. RTBC

  • drunken monkey committed 41b95cc on 8.x-1.x authored by isramv
    Issue #2794295 by isramv, drunken monkey, alan-ps: Fixed default index...
drunken monkey’s picture

Status: Reviewed & tested by the community » Fixed

Good to hear, thanks for testing!
Committed.
Thanks again, also, to isramv!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.