When logged in as admin, I sometimes get duplicate collapsers (the +/- things you click on). It's because the attach code is being run twice. Once as normal, and another time as part of an AJAX thing.

The attached patch works, but it paints over the problem of duplicate attach calls. I don't know why it happens.

CommentFileSizeAuthor
#8 interdiff-2793863-5-8.txt1.46 KBmradcliffe
#8 2793863-8.patch599 bytesmradcliffe
#5 views_tree-duplicate_collapsers-2793863-5.patch1.06 KBMykola Antoshchuk
#4 views_tree-duplicate_collapsers-2793863-4-D7.patch592 bytesrooby
views_tree_no_duplicate_collapsers_1.patch919 bytesmathieso

Comments

mathieso created an issue. See original summary.

stephen ollman’s picture

stephen ollman
Location Canberra
commented

I can confirm this issue started after the latest update.

Patch also fixes the issue for me too.

Thanks!

rooby’s picture

rooby commented
Status: Needs review » Needs work

This solution will break things if views trees were added using ajax. In that case the trees would not be processed.

It would be better to use jQuery.once

rooby’s picture

rooby commented
StatusFileSize
new views_tree-duplicate_collapsers-2793863-4-D7.patch592 bytes

Here is a D7 patch that fixes it.

Leaving as needs work since it is still a d8 issue for now.

Mykola Antoshchuk’s picture

Mykola Antoshchuk commented
StatusFileSize
new views_tree-duplicate_collapsers-2793863-5.patch1.06 KB

Here is a D8 patch.

alphawebgroup’s picture

alphawebgroup
he/him
Primary language English
Location Kyiv / Toronto
commented
Assigned: mathieso » Unassigned
Status: Needs work » Needs review
wombatbuddy’s picture

wombatbuddy commented

Confirm that the patch #5 fixed the issue
(also, the clearing of the browser's cache was needed).

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
StatusFileSize
new 2793863-8.patch599 bytes
new interdiff-2793863-5-8.txt1.46 KB

Missing jquery dependency - #2793823: Missing jQuery and jquery.once dependencies patch conflicts with this one. I'm uploading #5 but without the libraries.yml change so that both patches can be applied without conflicts.

I removed the double wrapped jQuery call as #2798323: Make provider prefix to username optional should solve that.

I also fixed the patch file to be a git diff rather than using diff.

gaurav.kapoor’s picture

gaurav.kapoor commented

#8 resolves the issue of the duplicate of collapsers and also produces a cleaner UI.

  • mradcliffe authored df45b8b on 8.x-2.x 
    Issue #2793863 by mradcliffe, rooby, mathieso, Mykola Antoshchuk:...
gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.