Follow-up to #2695297: Refactor EntityFile and use process plugins instead

Problem/Motivation

Unit test suite fails out of the box using the phpunit runner.

There were 4 errors:

1) Drupal\Tests\migrate\Unit\process\CopyFileTest::testSuccessfulCopies
mkdir(): No such file or directory

/var/www/testing/core/tests/Drupal/KernelTests/Core/File/FileTestBase.php:67
/var/www/testing/core/tests/Drupal/KernelTests/KernelTestBase.php:278
/var/www/testing/core/tests/Drupal/KernelTests/KernelTestBase.php:232
/var/www/testing/core/tests/Drupal/KernelTests/Core/File/FileTestBase.php:39
/var/www/testing/core/modules/migrate/tests/src/Unit/process/CopyFileTest.php:34

2) Drupal\Tests\migrate\Unit\process\CopyFileTest::testSuccessfulMoves
mkdir(): No such file or directory

/var/www/testing/core/tests/Drupal/KernelTests/Core/File/FileTestBase.php:67
/var/www/testing/core/tests/Drupal/KernelTests/KernelTestBase.php:278
/var/www/testing/core/tests/Drupal/KernelTests/KernelTestBase.php:232
/var/www/testing/core/tests/Drupal/KernelTests/Core/File/FileTestBase.php:39
/var/www/testing/core/modules/migrate/tests/src/Unit/process/CopyFileTest.php:34

3) Drupal\Tests\migrate\Unit\process\CopyFileTest::testNonExistentSourceFile
mkdir(): No such file or directory

/var/www/testing/core/tests/Drupal/KernelTests/Core/File/FileTestBase.php:67
/var/www/testing/core/tests/Drupal/KernelTests/KernelTestBase.php:278
/var/www/testing/core/tests/Drupal/KernelTests/KernelTestBase.php:232
/var/www/testing/core/tests/Drupal/KernelTests/Core/File/FileTestBase.php:39
/var/www/testing/core/modules/migrate/tests/src/Unit/process/CopyFileTest.php:34

4) Drupal\Tests\migrate\Unit\process\CopyFileTest::testRenameFile
mkdir(): No such file or directory

/var/www/testing/core/tests/Drupal/KernelTests/Core/File/FileTestBase.php:67
/var/www/testing/core/tests/Drupal/KernelTests/KernelTestBase.php:278
/var/www/testing/core/tests/Drupal/KernelTests/KernelTestBase.php:232
/var/www/testing/core/tests/Drupal/KernelTests/Core/File/FileTestBase.php:39
/var/www/testing/core/modules/migrate/tests/src/Unit/process/CopyFileTest.php:34

The listed failing tests are actually kernel tests so in the wrong namespace and so run as part of the wrong test suite. There may be an issue with kernel tests requiring a directory that doesn't exist as well.

Remaining tasks

Write patch to move new migate unit tests into kernel namespace.

User interface changes

n/a

API changes

n/a

Data model changes

n/a

CommentFileSizeAuthor
#3 2793091-2.patch696 bytesalexpott

Comments

neclimdul created an issue. See original summary.

mikeryan’s picture

Title: Refactor EntityFile and use process plugins instead » Refactor EntityFile "unit" test fails
alexpott’s picture

Status: Active » Needs review
StatusFileSize
new696 bytes
neclimdul’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix

since testbot is useless in this case, local review confirms this fixes the immediate error.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 2793091-2.patch, failed testing.

neclimdul’s picture

Status: Needs work » Reviewed & tested by the community

random failure trying to create the sequence table twice. Possibly related to #2791163: Random automatic testing failures on SQLite with PHP 5.5.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed f90c246 to 8.3.x and 89f13ed to 8.2.x. Thanks!

  • alexpott committed f90c246 on 8.3.x
    Issue #2793091 by alexpott, neclimdul: Refactor EntityFile "unit" test...

  • alexpott committed 89f13ed on 8.2.x
    Issue #2793091 by alexpott, neclimdul: Refactor EntityFile "unit" test...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.