Drupal\Component\Serialization\YamlSymfony\YamlSymfonyTest requires the YAML PHP extension which is obviously wrong. That prevents the test to be executed on a system that doesn't have the YAML extension and just uses the symfony fallback.

CommentFileSizeAuthor
#2 2792831_no_yaml_extension.patch540 bytesmkalkbrenner

Comments

mkalkbrenner created an issue. See original summary.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Version: 8.2.x-dev » 8.3.x-dev
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 2792831_no_yaml_extension.patch540 bytes
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix

Oh yeah that's totally right. I bet it was just copied from \Drupal\Tests\Component\Serialization\YamlPeclTest.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Priority: Normal » Major

Without this patch the test doesn't run at all because the YAML extension is missing at the testbots. That hides issues.

cilefen’s picture

cilefen commented

I agree, this is the inverse of, but just as important as, one of the definitions of a Major bug:

Cause test failures in environments not supported by the automated testing platform.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Related issues: +#2792877: Symfony YAML parser fails on some strings when running PHP 7, +#2792843: Drupal crashes after exporting and re-importing Solr field configs
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed f251506 to 8.3.x and d639691 to 8.2.x. Thanks!

  • alexpott committed f251506 on 8.3.x 
    Issue #2792831 by mkalkbrenner: YamlSymfonyTest must not require PHP...

  • alexpott committed d639691 on 8.2.x 
    Issue #2792831 by mkalkbrenner: YamlSymfonyTest must not require PHP...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.