Problem

Chosen seems to now do well to determine the width needed. Removing the minimum width as a required field will allow users to let that be an option.

Proposed Resolution

Remove required minimum width setting.

CommentFileSizeAuthor
#11 2790897-11-remove-width-required.patch1.9 KBmr.york
#2 2790897-2-remove-width-required.patch2.13 KBjoelpittet

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
StatusFileSize
new 2790897-2-remove-width-required.patch2.13 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2790897-2-remove-width-required.patch, failed testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Version: 7.x-2.x-dev » 7.x-1.x-dev
Status: Needs work » Needs review
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Version: 7.x-1.x-dev » 7.x-2.x-dev

That's weird, it applies locally to 2.x branch

Status: Needs review » Needs work

The last submitted patch, 2: 2790897-2-remove-width-required.patch, failed testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Needs review

Ah because there is no tests for this module but tests are turned on.

mr.york’s picture

mr.york commented
Status: Needs review » Reviewed & tested by the community

Works for me.

nagy.balint’s picture

nagy.balint commented
Status: Reviewed & tested by the community » Patch (to be ported)

Thanks Committed.

mr.york’s picture

mr.york commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 2790897-11-remove-width-required.patch1.9 KB

Patch ported to d8.

  • nagy.balint committed 0a7a296 on 8.x-2.x authored by mr.york 
    Issue #2790897 by joelpittet, mr.york: Let the width be flexible
nagy.balint’s picture

nagy.balint commented
Status: Needs review » Fixed

Thanks, Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.