Disable submit button until a selection is made

+1 for this improvement. The patch #2 works well.

I'd like to propose another approach. The patch #2 seems to add an alert box when the submit button is clicked. I believe, we can use the HTML "disabled" property directly to disable buttons.

This patch introduces the following function in VBO views:

• Submit buttons are enabled only when at least one item is checked and an item is selected in the operation selectbox.
• In other words, submit buttons are disabled if no item is checked in the list or no item is selected in the operation selectbox.

(To support bulk select checkboxes, we should write JS code instead of using #states API, I think.)

I like this a lot, it works with the select and the actions as a button. Hopefully admin themes style [disabled] which would make this every better.

I've committed this to the dev branch.

@joelpittet, thank you!

It work on "Table" format, but it doesn't work on "Unformatted list" format and "Select all items on this page" checkbox.

See attached view export.

Thank you, @Plazik. Surely "Select all items on this page" checkbox isn't supported by the patch #3.

I created a new patch to support the "Unformatted list" format additionally. As the patch #3 has no problem with the "Table" format and IMHO it's OK to just add a new patch, I think. I'd like someone to review this.

The following change in this patch is not for supporting "Unfromatted list". This is just an adjustment for consistency with the existing code :)

-    var checkedCheckboxes = $('input.vbo-select:checked', form);
+    var checkedCheckboxes = $('.vbo-select:checked', form);

That work and fixes the format that's not the table. And we don't need the polyfix for removeProperty because checked and disabled are both boolean properties, so true/false works for both.

Thanks for testing @Plazik, didn't test that scenario.

The patch I committed for posterity.

It works, thank you.

@joelpittet @Plazik thanks!

@hgoto could you checkout a couple issues that have arisen from this change to see if you can help?

• #2855782: Disable submit button works only after a second selection is done: Recent jQuery+WholeRowClickable
• #2855939: Bulk operation buttons don't work after upgrade to 3.4 when Force Single selected.

@joelpittet thank you for sharing the issues! Yes, I'll check them. (I'm sorry for introducing the problems.)

No worries, it's bound to happen without tests and JS test are a bit tricky in 7 to boot.

***EDIT*** still investigating

ignore this comment
ignore patch
different issue.

here instead #2856944: 'Please select at least one item' - after upgrading to 7.x-3.4