As per coding standard documentation at 'https://www.drupal.org/coding-standards/docs', @file tag docblock should not be there in the files that contain a namespaced class/interface/trait, whose file name is the class name with a .php extension.

CommentFileSizeAuthor
#6 remove_file_docblock-2789281-7.patch2.52 KBPradnya Pingat
removed-file-docblock-utc.patch2.68 KBaks22

Comments

aks22 created an issue. See original summary.

dishabhadra’s picture

dishabhadra commented
Status: Needs review » Reviewed & tested by the community

RTBC

dishabhadra’s picture

dishabhadra commented
Status: Reviewed & tested by the community » Needs work

Please ignore the previous comment, The patch failed to apply.

kunalkursija’s picture

kunalkursija commented

The patch did not work for me. Also the patch naming conventions are not proper.

Please check this documentation for patch naming conventions.

https://www.drupal.org/project/age_calculator/git-instructions

sneha_surve’s picture

sneha_surve commented
Assigned: aks22 » sneha_surve
Pradnya Pingat’s picture

Pradnya Pingat commented
Assigned: sneha_surve » Pradnya Pingat
Status: Needs work » Needs review
StatusFileSize
new remove_file_docblock-2789281-7.patch2.52 KB
Pradnya Pingat’s picture

Pradnya Pingat commented
Assigned: Pradnya Pingat » Unassigned
rasikap’s picture

rasikap commented
Assigned: Unassigned » rasikap
rasikap’s picture

rasikap commented
Assigned: rasikap » Unassigned
Status: Needs review » Reviewed & tested by the community

Could apply patch #6

kunalkursija’s picture

kunalkursija commented
Issue tags: +DrupalMumbaiCodeSprint16
shylajaphp’s picture

shylajaphp commented
Assigned: Unassigned » shylajaphp

I am working on it.

shylajaphp’s picture

shylajaphp commented

+1 for RTBC.
patch #6 is following file tag naming convention.

shylajaphp’s picture

shylajaphp commented
Assigned: shylajaphp » Unassigned

  • kunal.kursija committed 05df38c on 8.x-2.x authored by aks22 
    Issue #2789281 by Pradnya Pingat, aks22: Remove @file tag docblock from...
kunalkursija’s picture

kunalkursija commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch #6.
Have committed this to 8.x-2.x branch, Which will feature a release soon.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.