Hi there,
my theme sets padding for the a element, which means the help icon has to big dimensions and the part of the next sprite can be seen. This patch adds padding: 0px; to the advanced-help-link class. The other one is for the views module's configuration sprites (same issue).

CommentFileSizeAuthor
views-override-padding-for-icon-sprites.patch293 byteseMPee584
advanced_help-override-padding-for-help-icon.patch263 byteseMPee584

Comments

merlinofchaos’s picture

merlinofchaos commented

Since there are patches for different modules, should the theme not just provide this as its own override? I'm not entirely sure that's right, but it's difficult for modules to be completely defensive about their CSS, and themes which are doing a lot of work sometimes have to make sure they don't blow up modules.

eMPee584’s picture

eMPee584 commented

well this is an important thing sprites have to care about: a 0 padding! And many themes might set very general rules that would mess this up, while those required for these sprites are very specific... the padding for the help icon could also have gone into the views css as that extends the .advanced-help class, but this module's css is the origin of it so i thought it's better suited here. And i only attached the views patch here aswell because i now you are swinging your wand on both modules ;)

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed
Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.