Properly deprecate getUserName() and use getAccountName() instead

drupal_set_message($this->t('Another user (%other_user) is already logged into the site on this computer, but you tried to use a one-time link for user %resetting_user. Please <a href=":logout">log out</a> and try using the link again.',
            array('%other_user' => $account->getDisplayName(), '%resetting_user' => $reset_link_user->getDisplayName(), ':logout' => $this->url('user.logout'))), 'warning');

We should exchange the url() method with the equivalent. Is it urlgenerator()?

Submitting a patch against 8.3.x version.Replaced all the instances of getUsername() with getDisplayName().

I have rerolled the patch for 8.2.x version.
Replaced all the instances of getUsername() with getDisplayName().

rerolled the patch as per requirement.

Any Update on this issue ?

The scope creep in #3 makes this a duplicate of #2629286: Use getDisplayName() for user names consistently

1. +++ b/core/modules/user/src/Controller/UserController.php
   @@ -121,7 +121,7 @@ public function resetPass(Request $request, $uid, $timestamp, $hash) {
   -            array('%other_user' => $account->getUsername(), '%resetting_user' => $reset_link_user->getUsername(), ':logout' => $this->url('user.logout'))), 'warning');
   +            array('%other_user' => $account->getDisplayName(), '%resetting_user' => $reset_link_user->getDisplayName(), ':logout' => $this->url('user.logout'))), 'warning');
   

   I'm not sure this is the correct change. You're logged in as a user and you got the password reset link for another. In both cases according to the docs we should be using getAccountName() no - because here we are dealing with log in details.

2. +++ b/core/modules/user/src/Controller/UserController.php
   @@ -268,7 +268,7 @@ public function userPage() {
   -    return $user ? ['#markup' => $user->getUsername(), '#allowed_tags' => Xss::getHtmlTagList()] : '';
   +    return $user ? ['#markup' => $user->getAccountName(), '#allowed_tags' => Xss::getHtmlTagList()] : '';
   

   This was changed by #2746065: Profile page's title/heading does not fulfill hook_user_format_name_alter to getDisplayName() and that's right because this is displayed to all users and not login information.

I've updated the issue summary to reflect the full scope of work to carry out here. Now fixing the title.

1. +++ b/core/modules/user/src/Form/UserPasswordForm.php
   @@ -139,7 +139,7 @@ public function submitForm(array &$form, FormStateInterface $form_state) {
   +      $this->logger('user')->notice('Password reset instructions mailed to %name at %email.', array('%name' => $account->getDisplayName(), '%email' => $account->getEmail()));
   

   This should be getAccountName() - it is a log message.

2. +++ b/core/modules/user/src/Form/UserPasswordResetForm.php
   @@ -38,12 +38,12 @@ public function getFormId() {
   -      $form['message'] = array('#markup' => $this->t('<p>This is a one-time login for %user_name and will expire on %expiration_date.</p><p>Click on this button to log in to the site and change your password.</p>', array('%user_name' => $user->getUsername(), '%expiration_date' => $expiration_date)));
   +      $form['message'] = array('#markup' => $this->t('<p>This is a one-time login for %user_name and will expire on %expiration_date.</p><p>Click on this button to log in to the site and change your password.</p>', array('%user_name' => $user->getDisplayName(), '%expiration_date' => $expiration_date)));
          $form['#title'] = $this->t('Reset password');
        }
        else {
          // No expiration for first time login.
   -      $form['message'] = array('#markup' => $this->t('<p>This is a one-time login for %user_name.</p><p>Click on this button to log in to the site and change your password.</p>', array('%user_name' => $user->getUsername())));
   +      $form['message'] = array('#markup' => $this->t('<p>This is a one-time login for %user_name.</p><p>Click on this button to log in to the site and change your password.</p>', array('%user_name' => $user->getDisplayName())));
   

   This is login details stuff - imo should getAccountName()

3. +++ b/core/modules/user/src/Tests/UserBlocksTest.php
   @@ -67,7 +67,7 @@ function testUserLoginBlock() {
   -    $edit['name'] = $user->getUsername();
   +    $edit['name'] = $user->getDisplayName();
   

   getAccountName()

4. hmmm... let's try converting everything to getAccountName() - since that's the no change patch and then reviewing whether getDisplayName() should be used in any of the cases.

As #14 points out #2629286: Use getDisplayName() for user names consistently is prior art and actually is the single issue where all this should be fixed :( ho hum going to update that issue now. Closing a duplicate

Thought about this some more. What we can do here is do the proper deprecation and then in #2629286: Use getDisplayName() for user names consistently do the proper usage part. This means that issue will have less to do.

The username/accountname/displayname conversion is already done in #2629286: Use getDisplayName() for user names consistently. Do not break all efforts, please!

@hass please read and understand https://www.drupal.org/core/scope there is a reason why https://www.drupal.org/project/drupal/issues/2629286 is taking ages to get done.

For a longer explanation of #25 see #2629286-165: Use getDisplayName() for user names consistently

We can split the AccountName/Display name out of the other patch and follow up with tests later. ONLY the tests hold the other case back and this is caused by bugs committed for several years to core. The rest of the patch is fine and all you'd like to commit here.

Looks good.

Rerolled on top of 8.7.x HEAD. There were three very minor conflicts:

Applying: Init commit
Recorded resolution for 'core/modules/system/tests/modules/session_test/session_test.module'.
Recorded resolution for 'core/modules/user/tests/src/Functional/UserBlocksTest.php'.
Recorded resolution for 'core/modules/user/user.module'.

And this is why we need to do proper deprecations. Because new usages creep in.