Problem/Motivation

The module is missing some config schema

Proposed resolution

Add it :)

Ideally maybe even write a test for the module :)

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 contact_block-block-schema-2786777-2.patch370 bytessutharsan

Comments

dawehner created an issue. See original summary.

sutharsan’s picture

sutharsan commented
Status: Active » Needs work
Issue tags: +Needs tests
StatusFileSize
new contact_block-block-schema-2786777-2.patch370 bytes

Attached patch adds the schema. Now needs tests.

dawehner’s picture

dawehner
Primary language German
commented

+1 for the patch so far

sutharsan’s picture

sutharsan commented

@dawehner do you know a (block) schema test that can serve as an example?

sutharsan’s picture

sutharsan commented

By GaborHojtsy in IRC: "I am not sure one specifically exists for blocks, the ConfigTranslationUiTest has tests for contact translation, views translation, field translation, etc. but does not seem to have for block"

arijits.drush’s picture

arijits.drush
Primary language English
Location India
commented
Status: Needs work » Needs review
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

We could argue that we could postpone the tests until general tests for this module are written.

  • Sutharsan committed 3ea0a96 on 8.x-1.x 
    Issue #2786777 by Sutharsan: Missing config schema
sutharsan’s picture

sutharsan commented
Status: Reviewed & tested by the community » Fixed

Sorry for the delay.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.