Problem/Motivation
According to the help text when placing a block on specific pages /user would place a block on the current user's page, but the block does not show up there.
Placing it on/user/* for every user page does work.
If the help text is wrong and the path isn't in fact /user then the help text that gives this example needs changing because it's the only place where users find out how to place a block on a user page.
Alternatively it's is a bug.
The current user's page is not actually /user but something like /user/123, but a logged in user is directed to their own user page when they type that in.
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | placing_blocks_on-2785657-10.patch | 1.07 KB | mathieso |
| #9 | interdiff-3-to-6.txt | 1.01 KB | mathieso |
| #7 | placing_blocks_on-2785657-6.patch | 1.08 KB | mathieso |
| #7 | 2785657-3-to-5-interdiff.txt | 1.07 KB | mathieso |
| #3 | placing_blocks_on-2785657-3.patch | 1.07 KB | dishabhadra |
Comments
Comment #2
tim.plunkettI would just remove the part about /user from \Drupal\system\Plugin\Condition\RequestPath::buildConfigurationForm(), it is misleading.
Comment #3
dishabhadra commentedI think help text which is provided we need to change that because the current user's page is not actually /user but something like /user/123.
Adding patch to changing the description.
Let me know this approach is fine.
Comment #4
mathieso commentedDownloaded the patch, ran it. The wording matches the need:
Specify pages by using their paths. Enter one path per line. The '*' character is a wildcard. Example paths is /user/* for every user page. <front> is the front page.
One change: perhaps "Example paths is" should be "An example path is".
Comment #5
mathieso commentedI'll create a patch to make the change.
Comment #6
mathieso commentedComment #7
mathieso commentedChanges this from#3:
Specify pages by using their paths. Enter one path per line. The '*' character is a wildcard. Example paths is /user/* for every user page. is the front page.
Changed "Example paths is" to "An example path is"
...to...
Specify pages by using their paths. Enter one path per line. The '*' character is a wildcard. An example path is /user/* for every user page. <front> is the front page.
Comment #9
mathieso commentedSorry, messed up the interdiff in #7.
Comment #10
mathieso commentedSorry, #7 patch failed because I made it from modules/, rather than /core/modules.
Trying again.
Comment #11
mathieso commentedComment #12
yesct commentedLooked at the patch, does the recommended solution of taking out the /user example, and fixes the grammar cause it's just one example in that sentence.
No coding standard problems.
:)
Comment #13
alexpottIs this fixing this the right way - I think I would have expected /user to work - it obviously did at some point otherwise why would the text exist?
Comment #14
dawehnerD7 used to work like that ... you
/userpointing both to the current user page, as well as login page for the anonymous user. This got changed at some point in the early D8 cycle, before theuser.routing.ymlfile existed.Comment #15
dawehnerI hope this answers @alexpott's question.
Comment #16
catchRe-titling.
Comment #19
catchSince this is a bug in the description test, committed/pushed to both 8.3.x and 8.2.x. Tagging as a string change so it shows up in the release notes.
Comment #20
ifrikThanks for changing the wording.
I've opened a new issue to fix the regression that placing blocks on the current user's page is not possible anymore in D8 #2806541: Regression: Blocks cannot be placed on current user's page.