Closed (fixed)
Project:
Shortcode Video
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
16 Aug 2016 at 19:23 UTC
Updated:
9 Feb 2017 at 17:00 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
alexiswatson commentedPatch attached. Review and feedback welcome!
Comment #3
alexiswatson commentedPrevious was munged, disregard.
Comment #4
alexiswatson commentedOnce more, with feeling...
Comment #5
mforbes commentedThe docblocks also want to be patched...
shortcode_video_macro_process
* <iframe width="420" height="315"_shortcode_video_get_youtube_videoid
* <iframe width="420" height="315" src="http://www.youtube.com/embed/EJu8ihVdygY?rel=0" frameborder="0" allowfullscreen></iframe>Other than that, looks solid.
Comment #6
alexiswatson commentedUpdated documentation. One more for RTBC?
Comment #7
andrewmacpherson commentedTag clean up: "accessibility" is the preferred one. I know this issue is for a contrib module, but the "a11y" tag doesn't have many issues so I'm moving them all to "accessibility". This is so the core accessibility maintainers don't have to monitor two tags.
Comment #9
denes.szabo commented@davidwatson thanks for the patch!
Comment #10
denes.szabo commentedComment #11
denes.szabo commented