Comments

joyceg created an issue. See original summary.

joyceg’s picture

Assigned: joyceg » naveenvalecha
Status: Active » Needs review
StatusFileSize
new3.56 KB
joyceg’s picture

Assigned: naveenvalecha » Unassigned
joyceg’s picture

StatusFileSize
new5.94 KB
heykarthikwithu’s picture

Status: Needs review » Reviewed & tested by the community
alan d.’s picture

Priority: Normal » Minor
Status: Reviewed & tested by the community » Needs work

Sorry, being nit picky.

General style guide: https://www.drupal.org/node/2181737

Sometimes less is more.

INTRODUCTION
------------

The Search Configuration module has two primary functions, to alter how the
search form is rendered and to provide restrictions on the content that is
exposed when searching.

 * For a full description of the module, visit the project page:
   https://drupal.org/project/search_config

 * To submit bug reports and feature suggestions, or to track changes:
   https://drupal.org/project/issues/search_config

More whitespace would help a lot. i.e. Spaces between paragraphs:

....users during the search mechanism.

The key features are listed below:

Fairly verbose read, less text can be easier to follow:

CONFIGURATION
-------------

* Form Appearance

  Navigate to Administration » Configuration » Search » ??

  "Labels and string overrides" fieldset

  This section allows you to configure the field labels. Options include:
    - alter the field titles of the basic and advanced search forms
    - title position. These can be positioned above (default), below or hidden

.....

* Configure user permissions

  Navigate to Administration » People » Permissions:

  - Exclude nodes from search results

    This allows users with this permission to flag content as not to be searched.

Note there is a typo in exlusions / exlude, should be exclude / exclusions: #2785999: Search Config Permissions

Really do not see the need for "Functions used in the module:" section.

Generally do a blurb about the primary maintainers, adding full contributor list would get very large very fast :)

I'm not sure if I'm active or not, lol

And it is good to do the supporting companies & websites. One free back link for SEO.

MAINTAINERS
-----------
Current maintainers:
Naveen Valecha - https://www.drupal.org/u/naveenvalecha>
Joyce George - <https://www.drupal.org/u/joyceg>

Past maintainers:
Joseph Yanick - https://www.drupal.org/u/jbomb

This project has been sponsored by:
* Google
  This module has been ported to Drupal 8 as part of the Google Summer of Code 
  2016 project. Visit https://developers.google.com/open-source/gsoc/ for more
  information.

* Acquia
  Helped with time to mentor the GSOC student for the Drupal 8 port.
  Visit http://acquia.com for more information.

Others??

* GreenAcorn
  Drupal 7 port. Visit http://greenacorn.com.au for more information.
joyceg’s picture

Assigned: Unassigned » heykarthikwithu
Status: Needs work » Needs review
StatusFileSize
new3.03 KB
naveenvalecha’s picture

Status: Needs review » Needs work
  1. +++ b/README.txt
    @@ -1,3 +1,92 @@
    +See https://www.drupal.org/docs/8/extending-drupal/installing-contributed-modules for further information.
    

    Add the link of installing d8 modules

  2. +++ b/README.txt
    @@ -1,3 +1,92 @@
    +CONFIGURATION
    

    Add more details in the configuration section.

  3. +++ b/README.txt
    @@ -1,3 +1,92 @@
    +  Navigate to Administration » Configuration » Search » ??
    

    Why ??

  4. +++ b/README.txt
    @@ -1,3 +1,92 @@
    +.....
    

    Remove this line.

  5. +++ b/README.txt
    @@ -1,3 +1,92 @@
    +This project has been sponsored by:
    +* Google
    +  This module has been ported to Drupal 8 as part of the Google Summer of Code
    +  2016 project. Visit https://developers.google.com/open-source/gsoc/ for more
    +  information.
    +
    +* Acquia
    +  Helped with time to mentor the GSOC student for the Drupal 8 port.
    +  Visit http://acquia.com for more information.
    +
    +* GreenAcorn
    +  Drupal 7 port. Visit http://greenacorn.com.au for more information.
     
    

    Remove this section. Its worth mentioned on the project page.

joyceg’s picture

Status: Needs work » Needs review
StatusFileSize
new4.4 KB
naveenvalecha’s picture

Assigned: heykarthikwithu » Unassigned
Status: Needs review » Reviewed & tested by the community
Issue tags: +Novice

looks good

naveenvalecha’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x-1.x

  • naveenvalecha committed 83edf56 on 8.x-1.x authored by joyceg
    Issue #2783591 by joyceg, naveenvalecha, heykarthikwithu, Alan D.: Add...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.