\Drupal\field\Tests\FormTest::testFieldFormUnlimitedRequired says

    // Check that the label of the field input is visually hidden and contains
    // the field title and an indication of the delta for a11y.

but checks for js-form-required instead of visually-hidden.

CommentFileSizeAuthor
#2 2782967-2-visually-hidden.patch1.04 KBmikeker
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikeker created an issue. See original summary.

mikeker’s picture

mikeker CreditAttribution: mikeker as a volunteer commented
Status: Active » Needs review
Issue tags: +Accessibility
FileSize
2782967-2-visually-hidden.patch1.04 KB
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Drupalaton

Nice catch! I'm kind hoping that in the future these checks could be actually done in a "real" browser

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 2782967-2-visually-hidden.patch, failed testing.

mikeker’s picture

mikeker CreditAttribution: mikeker as a volunteer commented
Status: Needs work » Reviewed & tested by the community

As far as I can tell, the tests are all still passing for this patch. Returning to the status in #3.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

I checked for copy pasta and couldn't find any. Nice find.

Committed and pushed 73306d9 to 8.3.x and ad2227b to 8.2.x. Thanks!

  • alexpott committed 73306d9 on 8.3.x 
    Issue #2782967 by mikeker: FormTest::testFieldFormUnlimitedRequired...

  • alexpott committed ad2227b on 8.2.x 
    Issue #2782967 by mikeker: FormTest::testFieldFormUnlimitedRequired...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.