When you try to rename a field but you supply a field name that is too long, it clobbers the existing field. Seriously guys?

CommentFileSizeAuthor
#3 field_rename-2782179-3.patch640 bytesSnehal Brahmbhatt
Screen Shot 2016-08-10 at 11.39.34 AM.png96.67 KBnamklabs

Comments

namklabs created an issue. See original summary.

rudi teschner’s picture

rudi teschner commented

I've had the same problem recently and my "workaround" to fix the database issues that follow this error is to restore data and revision table, else the cronjobs will continue to mourn the missing table when deleting fields.

Snehal Brahmbhatt’s picture

Snehal Brahmbhatt commented
Status: Active » Needs review
StatusFileSize
new field_rename-2782179-3.patch640 bytes

@namklabs, Please find the below-attached patch for the same, here I added the max length validation for the new field name. Hope this works for your requirement.

Thanks

summit’s picture

summit commented

Could this patch be implemented please? Thanks in advance!

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Needs review » Reviewed & tested by the community

The patch installs cleanly and works as advertised.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Reviewed & tested by the community » Fixed

This is fixed in the latest snapshot 7.x-1.x-dev.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.