MetatagManager should use the instance name rather than plugin id to identify plugin instances

However, when doing this I discovered that in MetatagManager class the form method assumes that the array keys returned by the sortedTags method are plugin IDs, this is actually not the case when using derivatives as in my example module above. I don't know whether this is intentional or if there is some other way, but I wanted to submit this patch to allow plugin derivatives for metatag tags.

Actually given this stops derivers from being used I'm going to label this as something other than a feature request...

Could I raise this as an important patch because the use of 'id' as the plugin name is not 100% accurate, the 'name' property represents the plugin name. Thanks.

If the same plugin (id) is used for more than one instance (derivatives) then the MetatagManager will currently just hand back the last of these instances and ignore the rest.

This sort of fits in the grey area between bug and feature request, plugins definitions are originally keyed by name and not id, would be grateful if you had another look, thanks.

Yes, the groups also needed changing. I've made a few small updates to your patch.

• Missed a couple of instances where the plugin instance name should have been used.
• Also I reckon that '$included_groups' and '$included_tags' should be supplied with plugin instance name and should check for this, but also keeping the check for plugin id as well. For all existing cases plugin instance name and plugin id are the same, however this is mainly for derivative plugins where the id might be 'test_plugin' and the instance name might be 'test_plugin:first_one'. In this case it allows inclusion of all instances of a plugin or of specific tags. Not sure which way you'd like this to go?

Been thinking about this a bit more and I think it works having both plugin id and instance id. Leaving as-is.