Closed (fixed)
Project:
Scheduler
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
9 Aug 2016 at 14:14 UTC
Updated:
23 Oct 2016 at 18:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
jonathan1055 commentedHi Vinayak Kothule,
Thanks for noticing this. I have added links to the old and new functions in the issue simmary.
Your patch needs a bit of work, though:
Fatal error: Class 'Url' not foundbecause you forgot to adduse \Drupal\Core\Url;at the top.Url::fromRoute('entity.user.edit_form', ['user' => $user->id()])returns an object, when previously\Drupal::urlwas returning the actual string.Your patch passed because we do not actually have test coverage for the status report page yet. That is something that I might look to add in future. However, if you visit /admin/reports/status you can see the output manually.
Jonathan
Comment #3
vinayak kothule commentedComment #4
jonathan1055 commentedI have added tests to cover the status report page, on #2712465-2: [meta] 8.x-1.x test coverage. Now re-queueing the patch above, which should show the failures.
Comment #6
jonathan1055 commentedNo response from Vinayak, so here is a new patch. I added the necessary
use \Drupal\Core\Url;and both of the calls to Url::fromRoute needed->toString()Comment #8
jonathan1055 commentedCommitted. Thanks Vinayak for starting this issue.