Closed (fixed)
Project:
Imagefield Slideshow
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
9 Aug 2016 at 12:46 UTC
Updated:
6 Sep 2016 at 16:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
joshi.rohit100Needs to have a twig variable for buttons. Added a todo for twig variable
Comment #3
heykarthikwithuComment #4
heykarthikwithu@joshi.rohit100 and @navneet0693, as per #2 added the one's mentioned in todo, Please check this :)
Comment #5
joshi.rohit100shouldn't this be false or will affect the exiting installation.
shouldn't this be more verbose instead of 0 or 1 like 'Yes/No' ?
Also how about some theming/css for new buttons.
Comment #6
navneet0693 commentedAgreed with @joshi.rohit100 ! It should FALSE I guess. Taking up CSS task.
Comment #7
navneet0693 commentedComment #8
navneet0693 commentedComment #9
navneet0693 commentedResultant output.
Comment #10
joshi.rohit100screenshot is looking good to me. Just a question, not with screenshot but what if we have only one image ? :)
Comment #11
navneet0693 commentedThen prev-next may be of no use in such case, as it will repeat same image. We shouldn't hide them by default for only 1 value. We should leave choice to whether hide it or not.
Comment #12
joshi.rohit100Yes thats true that button will be of no use for one image button showing buttons when they are of no use is kind of a bad UX. But then again, choice is of maintainer :)
Comment #13
heykarthikwithuComment #14
heykarthikwithu1. Yup guys we should have FALSE by default and we should not show prev and next if we have only one image, i have added a piece of check please have a check of this.
2. @navneet0693 was not able to apply this patch seems image is missing, please change in the latest patch now
Comment #16
heykarthikwithuComment #17
heykarthikwithu@joshi.rohit100, i have committed with the changes mentioned and @navneet0693 you can create one more ticket if you need to work on styling part.
thank you guys..