If I add another navbar to my page in addition to the existing main menu "#navbar", the collapse feature for "#navbar" triggers the event for other navbars. Proposed patch on the way. data-target must target id and not class.

CommentFileSizeAuthor
#2 2779095-navbar-collapse-multiple.patch1.05 KBjduhls

Comments

jduhls created an issue. See original summary.

jduhls’s picture

jduhls commented
StatusFileSize
new 2779095-navbar-collapse-multiple.patch1.05 KB
markhalliwell’s picture

markhalliwell
Primary language English
commented
Title: navbar collapses ALL when multiple navbars » Use ID instead of selector for navbar toggle target
Version: 7.x-3.6 » 8.x-3.x-dev
Assigned: Unassigned » markhalliwell
Category: Bug report » Feature request
Issue tags: +Needs backport to D7

This feels like a rather extreme use case (i.e. not many sites will have more than one navbar).

I was tempted to just set this as "Closed (works as designed)" as things like this are meant to be overridden in sub-themes.

However, I appreciate the time you put into creating a patch for this and it's a relatively simple and non-intrusive change.

It needs to be committed to the 8.x-3.x branch (HEAD) first and then 7.x-3.x afterwards.

I'll work on the 8.x port. Thanks!

  • markcarver committed 0c541a1 on 8.x-3.x 
    Issue #2779095 by jduhls, markcarver: Use ID instead of selector for...

  • markcarver committed 45abd87 on 7.x-3.x authored by jduhls 
    Issue #2779095 by jduhls, markcarver: Use ID instead of selector for...
markhalliwell’s picture

markhalliwell
Primary language English
commented
Assigned: markhalliwell » Unassigned
Status: Active » Fixed
Issue tags: -Needs backport to D7
jduhls’s picture

jduhls commented

Simple and non-intrusive patch for your comment:

- This feels like a rather extreme use case (i.e. not many sites will have more than one
+ This is a rather awesome use case (i.e. not many sites will have more than one

;-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.