Hi,
I'm trying to customise the styling of the popup and I find the current implementation of it very rigid. You provide a template file so changing the layout is possible, but the background and text color inputs are required and cannot be disabled to completely add your own styling to the popup.
I need to move the background color to an inner div, but I see no other way now then to fill in a color and overwrite it in my own css. The text color however also gets the !important flag so to add different coloured text (header/body/button text) I need to change the classes in the template file and add my own css (which leaves a bogus style element in the of the page).
I'm not sure what the right/best way to handle this is, wether that's adding an option to disable the styling all together, or moving all the styling to a css file only, I don't know, but right now it's limiting and it feels like I need to hack it to make the popup according to the design.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | styling_options_too_rigid-2778259-1.patch | 1.62 KB | arijits.drush |
Comments
Comment #2
svenryen commentedThanks for the report. Definitely we have right now quite a few people using the module that rely on the current behavior (which also includes setting the color through !important), so we can't move the configuration to a css file and remove those options from the interface.
On the other hand, I like your idea of having an option to disable the colors provided in the admin interface if you are styling the popup yourself.
Comment #3
arijits.drushComment #4
travis-bradbury commentedI like the option provided by #3 since it helps and wont break existing sites, but there is a lot of problem css in the module's CSS file itself.
#id .class #id elementis very hard to override.#sliding-popup .popup-content #popup-buttons button). Themes already style buttons. To get buttons back to what buttons are supposed to look like on a site, you'll either have to undo every rule the module made (that's a lot!) or patch the module yourself to remove the excess.It may not be something that can be changed except in a major version update, but it'd be great if the module played nice with themes.
Comment #5
arijits.drushComment #7
svenryen commentedComment #8
svenryen commented