Hi, I'm testing the new -dev relase and the composer file contains an extra comma which throws the following error executing "composer drupal-update":

[UnexpectedValueException]
Could not decode JSON file composer.json Error message: unexpected character

The following patch simply remove the extra comma.

CommentFileSizeAuthor
#3 broken_composer_json-2776731-3.patch336 bytesrjarteta
composer_remove_comma.patch468 bytesfinex

Comments

FiNeX created an issue. See original summary.

finex’s picture

finex commented
Issue summary: View changes
rjarteta’s picture

rjarteta commented
StatusFileSize
new broken_composer_json-2776731-3.patch336 bytes

The new version of composer.json is also broken, attaching patch.

rjarteta’s picture

rjarteta commented

Sorry @FiNex, the patch didn't apply via drush make

  • jmuzz committed d71adfe on 8.x-1.x authored by FiNeX 
    Issue #2776731 by FiNeX, panche: Removed extra comma in composer.json...
jmuzz’s picture

jmuzz commented
Status: Active » Fixed

Thanks all.

@panche is right the patches should be made with the module directory as the base not the drupal install directory. It helps to follow the file naming conventions.

Issues should be set to "Needs Review" status when a patch is submitted.

  • jmuzz committed d71adfe on 8.x-3.x authored by FiNeX 
    Issue #2776731 by FiNeX, panche: Removed extra comma in composer.json...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.