Password expiration missing role and other policy checks on Cron

I have reviewed the code and it looks good to me. Testing soon to come.

Tested the code and looks good.

This mostly looks good and thank you for working on this.

I had some comments:

if (empty(array_intersect($policy->getRoles(), $user->getRoles())) || $user->hasPermission('Bypass password policies'))

This permission check seems awkward here. Should we consider adding a new "Bypass password reset" permission and use that as the check? There is still some awkwardness with administrative roles that have all permissions. For instance - if users intentionally want administrative roles to be reset - this permission check would always return true. This awkward relationship is outlined here: https://www.drupal.org/node/2735943

I think it's prudent to get this patch merged and solve the permission weirdness in 2735943.

Attempted to roll the patch and it fails. Can this please be re-rolled? I'll get it merged in then.

Thanks - can you test out https://www.drupal.org/node/2709935? Once that's good to go, that gets in and these patches come shortly thereafter :)

Attempted to merge patch in #13 and it fails based on the commit pushed from 2709935. Can you please re-roll once more? My apologies.

This looks good, I am merging.

Details:
Code review looks good.

Automated tests pass (for the base module).

PHPCS fails (but the issues have nothing to do with the submitted patch and have been cleaned up in the new patch for https://www.drupal.org/node/2774969):

FILE: ...les/contrib/password_policy/password_policy_characters/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
6 | WARNING | Line exceeds 80 characters; contains 114 characters
----------------------------------------------------------------------

FILE: ...d_policy/password_policy_history/password_policy_history.install
----------------------------------------------------------------------
FOUND 7 ERRORS AND 1 WARNING AFFECTING 6 LINES
----------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
6 | ERROR | [x] Missing function doc comment, only found file
| | comment
7 | ERROR | [x] No space found before comment text; expected "//
| | add current user passwords" but found "//add
| | current user passwords"
7 | ERROR | [x] Inline comments must start with a capital letter
7 | ERROR | [x] Inline comments must end in full-stops,
| | exclamation marks, colons, question marks, or
| | closing parentheses
9 | ERROR | [x] Namespaced classes/interfaces/traits should be
| | referenced with use statements
17 | WARNING | [x] A comma should follow the last multiline array
| | item. Found: )
61 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: ...rd_policy/password_policy_history/password_policy_history.module
----------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 9 LINES
----------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
4 | ERROR | [x] Function comment short description must start with
| | exactly one space
6 | ERROR | [x] Missing function doc comment, only found file
| | comment
11 | ERROR | [x] Function comment short description must start with
| | exactly one space
18 | ERROR | [x] Function comment short description must start with
| | exactly one space
18 | ERROR | [x] Doc comment short description must end with a full
| | stop
21 | ERROR | [x] Namespaced classes/interfaces/traits should be
| | referenced with use statements
22 | ERROR | [x] Expected 1 space after IF keyword; 0 found
38 | ERROR | [x] Function comment short description must start with
| | exactly one space
44 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: ...odules/contrib/password_policy/password_policy_history/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
4 | WARNING | Line exceeds 80 characters; contains 108 characters
----------------------------------------------------------------------

FILE: ...es/contrib/password_policy/src/Annotation/PasswordConstraint.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
47 | ERROR | Class property $error_message should use lowerCamel
| | naming without underscores
----------------------------------------------------------------------

Time: 1.05 secs; Memory: 13.25Mb

Is there any sign of this fix being rolled into a 3.0.0-alpha3 version?

Yes - we have one outstanding issue that will be rolled into the next alpha (and hopefully first beta) release