CS Review Tool (pareview.sh) outputed this, please fix the issues with *.
Review of the 7.x-1.x branch (commit ed64d73):
* - ESLint has found some issues with your code (please check the JavaScript coding standards).
/var/www/drupal-7-pareview/pareview_temp/js/pdf_export.js: line 59, col 27, Error - Missing space before function parentheses. (space-before-function-paren)
/var/www/drupal-7-pareview/pareview_temp/js/pdf_export.js: line 67, col 28, Error - Missing space before function parentheses. (space-before-function-paren)
2 problems
* - DrupalPractice has found some issues with your code, but could be false positives.
FILE: /var/www/drupal-7-pareview/pareview_temp/pdf_export.module
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
62 | WARNING | Do not use drupal_add_js() in hook_init(), move it to
| | your page/form callback or use hook_page_build() instead
--------------------------------------------------------------------------
Time: 59ms; Memory: 6Mb
- No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | fix_cs_issues-2771405-2.patch | 3.87 KB | fcampos |
Comments
Comment #2
fcampos commentedComment #3
fcampos commentedPatch sent with this and other CS issues fixed!
Comment #4
fcampos commentedComment #5
rhormens commented+RTBC
Comment #6
rhormens commentedComment #8
gabrielmachadosantos commented