CommentFileSizeAuthor
#14 css-modified-2768439-14.patch1.35 KBshreya shetty
#10 css-modified-2768439-10.patch496 bytesshreya shetty
#5 css-modified-2768439-4.patch19.63 KBshreya shetty
#3 css-modified-2768439-3.patch19.58 KBshreya shetty
#2 Asterisk.jpg6.98 KBshreya shetty
Astric.jpg6.98 KBshreya shetty

Comments

Shreya Shetty created an issue. See original summary.

shreya shetty’s picture

shreya shetty commented
StatusFileSize
new Asterisk.jpg6.98 KB
shreya shetty’s picture

shreya shetty commented
StatusFileSize
new css-modified-2768439-3.patch19.58 KB
shreya shetty’s picture

shreya shetty commented
Status: Active » Needs review
shreya shetty’s picture

shreya shetty commented
StatusFileSize
new css-modified-2768439-4.patch19.63 KB
markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs review » Needs work
Related issues: +#2274631: Form required marker "\204E" is broken in Google Chrome 35 / Internet Explorer 9, +#2691007: Required span not displayed in bootstrap panel, +#2152217: Remove theme_form_required_marker() from the theme system - use CSS instead

Well... crap :(

This was a change made in #2691007: Required span not displayed in bootstrap panel to be more inline with core.

That being said, it appears there was also the follow-up #2274631: Form required marker "\204E" is broken in Google Chrome 35 / Internet Explorer 9 which converted this to an SVG background image instead.

We'll likely need to do the following somehow :-/

Also, please do not edit the compiled source files. You must change the LESS startkerkit source files instead. They will be automatically compiled (for all versions) when a maintainer commits the changes.

markhalliwell’s picture

markhalliwell
Primary language English
commented
shreya shetty’s picture

shreya shetty commented

So are we replacing asterisk by an image ??

markhalliwell’s picture

markhalliwell
Primary language English
commented

That would appear to be the case :-/

shreya shetty’s picture

shreya shetty commented
Status: Needs work » Needs review
StatusFileSize
new css-modified-2768439-10.patch496 bytes

Thank you for the quick reply . I have done the css in overrides.less and committed the patch and also place the image in folder named images .

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs review » Needs work

There is already a rule for .form-required: http://cgit.drupalcode.org/bootstrap/tree/starterkits/less/less/componen...

Also, there is no image in the patch.

That being said, if we are going to go down the image route, I wonder if we can just use the image/svg that core already provides somehow?

shreya shetty’s picture

shreya shetty commented

I am unable to upload svg file . So the maintainer needs to take svg image from core and place it in images folder

markhalliwell’s picture

markhalliwell
Primary language English
commented

You don't upload it to here. You add it in the patch.

shreya shetty’s picture

shreya shetty commented
Status: Needs work » Needs review
StatusFileSize
new css-modified-2768439-14.patch1.35 KB

Thank you for your guidance . I have made some improvements . Hope this is the patch you are expecting .

  • markcarver committed 7fda72d on 8.x-3.x 
    Issue #2768439 by Shreya Shetty, markcarver: CSS of required field is...
  • markcarver committed e8b7827 on 8.x-3.x authored by Shreya Shetty
    Issue #2768439 by Shreya Shetty: CSS of required field is broken in...
markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.