As per coding standard documentation at 'https://www.drupal.org/coding-standards/docs', @file tag docblock should not be there in the files that contain a namespaced class/interface/trait, whose file name is the class name with a .php extension.

CommentFileSizeAuthor
#15 2766931-15.patch32.71 KBneslee canil pinto
#13 2766931-13.patch32.14 KBneslee canil pinto
#4 removed-file-docblock-2766931.patch37.25 KBddrozdik
#2 removed-file-docblock-2766931.patch12.94 KBaks22

Comments

aks22 created an issue. See original summary.

aks22’s picture

aks22 commented
Status: Active » Needs review
StatusFileSize
new removed-file-docblock-2766931.patch12.94 KB

Please find attached patch.

Status: Needs review » Needs work

The last submitted patch, 2: removed-file-docblock-2766931.patch, failed testing.

ddrozdik’s picture

ddrozdik commented
Status: Needs work » Needs review
StatusFileSize
new removed-file-docblock-2766931.patch37.25 KB

I have updated the patch.

ddrozdik’s picture

ddrozdik commented
Assigned: aks22 » ddrozdik
afi13’s picture

afi13 commented
Status: Needs review » Reviewed & tested by the community

Ok for me.

eclipsegc’s picture

eclipsegc commented

Ok, I'm fine with committing this, but it's going to break every other patch in the queue. Let me do a once over on existing patches and we may need to reroll this a few time before we're ready to actually commit it. Thx for this though. Nice to get up to speed on the new code standard.

Eclipse

andypost’s picture

andypost
he/him
Primary language Russian
commented

Closed duplicate #2820652: Remove @file tag docblock from all the .php files

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: ddrozdik » Unassigned
Parent issue: » #2787419: Plan for Page Manager 8.x-4.0 release

Don't forget to unassign the issue after you upload a patch.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 8.x-1.x-dev » 8.x-4.x-dev
manuel.adan’s picture

manuel.adan
Location 🌌
commented
Category: Bug report » Task
Status: Reviewed & tested by the community » Needs work

Patch no longer applies, file tag was removed from some files in previous commits.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Issue tags: +Needs reroll
neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 2766931-13.patch32.14 KB

Updated Patch

manuel.adan’s picture

manuel.adan
Location 🌌
commented
Status: Needs review » Needs work
Issue tags: -Needs reroll

It is almost ready. After the patch, I found only one remaining superfluous @file tag at:

tests/modules/page_manager_test/src/Controller/PageManagerTestController.php

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 2766931-15.patch32.71 KB

Updated Patch

manuel.adan’s picture

manuel.adan
Location 🌌
commented
Status: Needs review » Fixed

At last committed, thank's

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

aks22’s picture

aks22 commented