API page: https://api.drupal.org/api/drupal/core%21includes%21theme.inc/function/t...

The description for template_preprocess() starts with:

This function is called for theme hooks implemented as templates only, not for theme hooks implemented as functions.

That is the same sentence used for Drupal 7. Since in Drupal 8 there are just theme hooks implemented as templates, the sentence should be probably changed to say the following:

This function is called for every theme hook.

CommentFileSizeAuthor
#9 update-function-description-2765849-9.patch857 bytesavpaderno
#2 update-function-description-2765849-2.patch683 bytesavpaderno

Comments

kiamlaluno created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new update-function-description-2765849-2.patch683 bytes
markdorison’s picture

markdorison
he/him
commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: update-function-description-2765849-2.patch, failed testing.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
StatusFileSize
new update-function-description-2765849-9.patch857 bytes
mohit1604’s picture

mohit1604 commented
Status: Needs review » Reviewed & tested by the community

@kiamlaluno , Patch looks fine . Marking RTBC .

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: update-function-description-2765849-9.patch, failed testing. View results

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

I am changing the status back. I just set verified the patch was not failing the tests.

  • larowlan committed a0ce0b8 on 8.5.x 
    Issue #2765849 by kiamlaluno: The description for template_preprocess()...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed as a0ce0b8 and pushed to 8.5.x.

As per https://www.drupal.org/core/release-cycle-overview#current-development-c... 8.4 is in 'critical fixes only', so this can't be backported to 8.4

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.