Problem/Motivation

As a part of future mailhandler demo module we should add sample mail messages.

Proposed resolution

Add mail samples with PGP signed messages (inline, MIME, MIME HTML). Also, add an install hook that creates a sample node type, mailhandler role, mailhandler user.

CommentFileSizeAuthor
#5 add_sample_pgp_signed-2763033-5-interdiff.txt14.03 KBmbovan
#5 add_sample_pgp_signed-2763033-5.patch13.66 KBmbovan
#3 add_sample_pgp_signed-2763033-3.patch9.97 KBmbovan

Comments

mbovan created an issue. See original summary.

mbovan’s picture

mbovan commented
Parent issue: » #2731539: [META] Add demo module

Added parent issue.

mbovan’s picture

mbovan commented
Status: Active » Needs review
Related issues: +#2763027: Extend Inmail "Paste form" to support Mailhandler samples
StatusFileSize
new add_sample_pgp_signed-2763033-3.patch9.97 KB

The patch that adds sample PGP signed messages, info file and an install hook.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Needs work 
  1. +++ b/mailhandler_d8_demo/eml/PGP_Signed_MIME_HTML.eml
--- /dev/null
+++ b/mailhandler_d8_demo/keys/demo.key

    I think for demo maintenance purposes, we should also add the original private key you're using for this example...
    Otherwise we can't update the demo reproducible. Or you think whoever updates it should use an own key? 

  2. +++ b/mailhandler_d8_demo/mailhandler_d8_demo.install
@@ -0,0 +1,53 @@
+  $users = \Drupal::entityTypeManager()->getStorage('user')->loadByProperties(['mail' => 'mailhandlerd8user@gmail.com']);

    By coding standard, you are supposed to use example.com as example domain. Please update all your examples...
    https://www.drupal.org/coding-standards#example

mbovan’s picture

mbovan commented
Status: Needs work » Needs review
Related issues: +#2763463: Replace custom domain with example.com
StatusFileSize
new add_sample_pgp_signed-2763033-5.patch13.66 KB
new add_sample_pgp_signed-2763033-5-interdiff.txt14.03 KB

Re #4.1: Added a private key too. It can be useful as an easy start.

Re #4.2: Right. I didn't add it at first because I had to have a valid email address to send signed emails. Found a way to sign it in the other way.

Also, opened an issue for "example.com" domain #2763463: Replace custom domain with example.com.

  • mbovan committed 5273990 on 8.x-1.x 
    Issue #2763033 by mbovan, miro_dietiker: Add sample PGP signed mail...
mbovan’s picture

mbovan commented
Status: Needs review » Fixed

Committed #5.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.