In the issue #2731939: Add hooks to alter the behavior during the request translation to the translators we added the possibility to alter the result of getItems() in Job so now could be that during requestTranslation(), getItems() returns 0 items, that could lead to errors in the translators, so the best is to not request a translation in that case IMHO.

We also found this problem here #2730169-7: Implement ContinuousTranslatorInterface

CommentFileSizeAuthor
#3 do_not_request_a-2762739-3.patch779 bytesedurenye

Comments

edurenye created an issue. See original summary.

edurenye’s picture

edurenye commented
Issue summary: View changes
Related issues: +#2731939: Add hooks to alter the behavior during the request translation to the translators, +#2730169: Implement ContinuousTranslatorInterface
edurenye’s picture

edurenye commented
Status: Active » Needs review
StatusFileSize
new do_not_request_a-2762739-3.patch779 bytes

Done.

  • Berdir committed 9d74ad9 on 8.x-1.x authored by edurenye 
    Issue #2762739 by edurenye: Do not request a translation if a Job has no...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Would be good to have tests for those new hooks and behavior, can you open a follow-up for that?

Committed, thanks.

edurenye’s picture

edurenye commented

Done, here is the follow up #2763437: Add tests for the hooks that alter the behaviour during request translation

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.