Missing default.profile from the file system

Since the following lines are in the commited patch:

+  // 'Default' profile has been renamed to 'Standard' in D7.
+  // We change the profile here to prevent a broken record in the system table.
+  // See system_update_7049().
+  if ($profile == 'default') {
+    $profile = 'standard';
+    variable_set('install_profile', $profile);
+  }
+

I think we should fix this too.
Can you confirm that you have a record for "standard" and that status is 1 and that the value of the variable "install_profile" is "standard"?
If that's the case we only have to delete the old "default.profile".

Hm, this is pretty unfortunate - I can reproduce just by updating from 6.x to 7.44, then updating to the latest 7.x. (Updating from Drupal 6 to the latest 7.x directly is OK.)

It is probably the case for whatever profile the Drupal 6 site was using (not necessarily "default"). I'm not sure if we can safely delete any profile that's not in use from the {system} table, but maybe we can....

In the meantime I will at least add this issue to https://www.drupal.org/node/2487215. Unfortunately a lot of people might see this - update.php displays warnings on the screen even if the rest of the site isn't configured to (I think).

I suppose this is basically just exposing a bug that was there all along on sites that upgraded from Drupal 6. It is just now a lot more visible...

It is probably the case for whatever profile the Drupal 6 site was using (not necessarily "default").

Maybe it's mostly limited to default though. If you had another profile, you probably needed to keep it in place on upgrade (or else face other bugs)?

I think it's only limited to default as that profile actually got renamed by Drupal core.
If you rename a custom profile it's your own task to take care of the "migration".

We're thinking of adding the attached patch to the release (not as a final fix, but just to avoid error messages on lots of sites when we know the cause of the bug).

Or this one, which is just focused on this issue (the above is for #2761829: Getting drupal_trigger_error_with_delayed_logging errors on Drupal 7.x dev (7.50) too).

I like #8, but I feel this should be in its own issue and this one should focus on fixing the thing in 7.51.

I do think we might also be able to do something about the menu router problem, so the work around feels okay to me.

Created #2762393: Skip error triggering for missing files if the files are empty or "default"

Back to active for this issue then. When fixing it for real in this issue, we should remove that @todo (and most/all of that code).

Adding as a bugfix target.

>> Comment #13 by David_Rothstein said "Back to active for this issue then"

Does that mean this issue needs to be put back into https://www.drupal.org/node/2487215 - I only found this issue because I looked at the revision history for https://www.drupal.org/node/2487215 and noticed that this had been removed from there now the issue is fixed.

@JamesOakley no need, we implemented a workaround in #2762393: Skip error triggering for missing files if the files are empty or "default"

Completely untested, but maybe something like the attached?

I added several conditions to the delete query that might not be strictly necessary, but want to be extra sure we don't accidentally delete a real Drupal 7 profile (e.g. with the same name) that's actually in use somehow.

I'm still curious exactly what happens if you run into this with a different install profile than "default", but I guess sites in that situation already have errors due to #1170362: Install profile is disabled for lots of different reasons and core doesn't allow for that and this issue would just be another error message on top of the existing ones...

I would RTBC this, but this needs manual testing. The patch looks good to me though.

I ran across this error on a site that was imported from D6 to D7. I applied the patch without issue. Ran the update and the missing module messages stopped.

Marking the RBTC.

Thanks @wylbur for testing

Committed and pushed to 7.x, thanks!