as usual, unipped 8.14 in the directory in its own folder, then copied to the core director. Then running update.php, or trying to access any other page, generates:

"The website encountered an unexpected error. Please try again later."

Restoring 8.1.3 now generates error on all pages:
"Parse error: syntax error, unexpected 'class' (T_CLASS), expecting identifier (T_STRING) or variable (T_VARIABLE) or '{' or '$' in /home/udcadmin/public_html/core/lib/Drupal/Core/Controller/ControllerResolver.php on line 145"

CommentFileSizeAuthor
#18 2761865-18.patch814 bytescatch
#17 2761865-16.patch528 bytescatch

Comments

shadowmihai created an issue. See original summary.

shadowmihai’s picture

Okay, after re-uploading/changing from 8.13 to 8.14 several times with the same error, I deleted the folders core, profile, sites and vendors, then copied over the 8.14 files again.

This produced the same error, but when I went to the site root, it loaded the install page, as if a new install. I entered the database info and it directed me to run update.php for just an update

Although the update.php was generating the same error, when I used the link from the install page, it updated fine and the site seems to be running now.

I have three other drupal 8 sites and am reticent to update to 8.14 until I know what happened here... I followed the EXACT same procedure for updating all my sites for the last several years with never an issue so there must be something different in this release package...

catch’s picture

Status: Active » Postponed (maintainer needs more info)

There's no syntax error in that file, so this looks like an issue with your environment or an unlucky unzip.

Can you test on a copy of your other sites?

alexpott’s picture

Also @shadowmihai can you export your core.extension.yml using /admin/config/development/configuration/single/export and paste the contents here?

alexpott’s picture

I've downloaded the zip and extracted it over 8.1.4 and the differences are as expected - the .yml files have info added by the packager. Just checking @shadowmihai did you follow the procedures documented in https://www.drupal.org/node/2700999 and remove /core and /vendor first before copying in the contents from the zip file.

Anonymous’s picture

alexpott, thank you for #5.

I'm also get error when override these folders, but another:

Got error 'PHP message: Symfony\\Component\\DependencyInjection\\Exception\\ServiceNotFoundException: You have requested a non-existent service "password_migrate". in /var/www/my_best_site/src/vendor/symfony/dependency-injection/ContainerBuilder.php on line 819\n'

remove /core and /vendor first before copying is really helped!

bmateus’s picture

Drupal 7 core updates were ok, not much stress. But these ones are freaking me out already.

Just updated from 8.1 to 8.5 and of course, I've f*ckd it up. Had to search this page again for some time, because "The website encountered an unexpected error. Please try again later." is not the friendliest of error notifications.

After following these guidelines, it went online again. Still getting a 500 server error when running update.php, though.

While waiting for some 13.000 files to upload, I reflected on the matter.

I truly understand Drupal 8 is a massive beast of a software, but I agree that security and core updating process should be reviewed. Not saying it should mimick Wordpress (the code layering and complexity is not even comparable), but it should also have not-so-technical small-site admins in mind. At least, better error notification, so a non tech can know where to look more about its problem at hand.

I do think that failing to improve core updates may feed back as a reputation problem, with smaller projects choosing other platforms due to (their) lack of technical response. Not always the best tech is the most popular (WP, for example).

Just my two cents. Still loving Drupal.

paintingguy’s picture

Same, after installing 8.1.4 my site is now broken and I do not now what to do.
The website encountered an unexpected error. Please try again later.

cilefen’s picture

Hi @paintingguy

Please post the error that is logged. We have no way of knowing what that means if not.

Did you follow the upgrade instructions linked in #5?

paintingguy’s picture

No, I did not follow #5. I also just tried 8.1.5 and this also broke the site. Rolling back to 8.1.3 works fine.

paintingguy’s picture

Sorry, I can't provide the error log, I have only minute right now to spare. But I rolled back to 8.1.3 and my site is back. Thanks for the hard work. I look forward to being able to update it when this is resolved. Sorry I cannot help more right now.

paintingguy’s picture

As per update instructions:

Remove the 'core' and 'vendor' directories. Also remove all of the files in the top-level directory, except any that you added manually.

I've never done this but it appears I should be. Do I remove "my" core and vendor directories, or the "update" core and vendor directories?

catch’s picture

You remove the existing core and vendor directories, then copy the new core and vendor directories over them.

catch’s picture

Status: Postponed (maintainer needs more info) » Needs review

Here's a patch to add back those files empty.

Note this will not fix a site that's already been updated incorrectly (it won't even apply) - you should either redo the process following the upgrade instructions, or delete those two files manually.

However if we apply this to core and put out a new patch release, it should prevent the error on sites that do the upgrade.

catch’s picture

StatusFileSize
new528 bytes
catch’s picture

Version: 8.1.4 » 8.1.x-dev
StatusFileSize
new814 bytes

More informative comment.

The last submitted patch, 17: 2761865-16.patch, failed testing.

alexpott’s picture

Status: Needs review » Reviewed & tested by the community

I like this solution... I've checked all deletes since 8.1.0...

git diff --name-status 8.1.0 8.1.5 | grep "^D" | grep -v "Test.php$"
D	core/modules/migrate/tests/modules/template_test/migration_templates/migrate.migration.node_template.yml
D	core/modules/migrate/tests/modules/template_test/migration_templates/migrate.migration.other_template.yml
D	core/modules/migrate/tests/modules/template_test/migration_templates/migrate.migration.url_template.yml
D	core/modules/migrate/tests/modules/template_test/template_test.info.yml
D	core/modules/update/tests/modules/update_test/src/MockFileTransfer.php
D	core/modules/user/src/MigratePassword.php
D	core/modules/user/src/UserServiceProvider.php

So these are definitely the only two we need to worry about.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 01e7deb and pushed to 8.1.x and 8.2.x. Thanks!

We need to create a policy about this somewhere.

diff --git a/core/modules/user/src/MigratePassword.php b/core/modules/user/src/MigratePassword.php
index 9adb4fe..79715df 100644
--- a/core/modules/user/src/MigratePassword.php
+++ b/core/modules/user/src/MigratePassword.php
@@ -1,4 +1,5 @@
 <?php
+// @codingStandardsIgnoreFile
 // This file is intentionally empty so that it overwrites when sites are
 // updated from a zip/tarball without deleting the /core folder first.
 // @todo: remove in 8.3.x
diff --git a/core/modules/user/src/UserServiceProvider.php b/core/modules/user/src/UserServiceProvider.php
index 9adb4fe..79715df 100644
--- a/core/modules/user/src/UserServiceProvider.php
+++ b/core/modules/user/src/UserServiceProvider.php
@@ -1,4 +1,5 @@
 <?php
+// @codingStandardsIgnoreFile
 // This file is intentionally empty so that it overwrites when sites are
 // updated from a zip/tarball without deleting the /core folder first.
 // @todo: remove in 8.3.x

The files failed coding standards checks - since they are not code per se lets ignore them.

  • alexpott committed 5c4f93f on 8.2.x
    Issue #2761865 by catch, alexpott: Update from 8.13 to 8.14 breaks site...

  • alexpott committed 01e7deb on 8.1.x
    Issue #2761865 by catch, alexpott: Update from 8.13 to 8.14 breaks site...
catch’s picture

Once the development tarball is updated, it would be great if people who've run into this issue could upgrade to the tarball and see if that fixes it for you.

bmateus’s picture

@cilefen: Thanks for the links! I'm glad to see that it really is being looked after.

After the update, I still get a funky error: when running update.php or flushing the cache, I get a 500 error.
The drupal log reports:

Location https://xxxxxx.co.net/backoffice/admin/flush?token=KLubHrDERPDdnW2CDtIJn...
Referrer https://xxxxxx.co.net/backoffice/admin/content
Message Notice: Undefined property: Drupal\services\Plugin\Deriver\EntityGet::$entityTypeManager in Drupal\services\Plugin\Deriver\EntityGet->getDerivativeDefinitions() (line 16 of /var/www/vhosts/xxxxxx.co.net/httpdocs/backoffice/modules/services/src/Plugin/Deriver/EntityGet.php).

In my Status report I got this: Token types are not defined but have tokens: $info['types']['entity'], which should be involved with the drupal log. To me, it feels like a module may be buggy.

Assuming this may be a module problem, I proceded to disable third-party modules, only to realize that another glitch has started: I can still enable new modules, but can't disable enabled modules.

I'm still looking into what it may be causing this, but it shows why sometimes some get shivers when updating core.

catch’s picture

@bmateus you need to uninstall modules - note that this will remove any configuration or data they provide, so better to do it on a copy of your site/database, not the live one.

The issue you're having is in services module, so I'd suggest checking the issue queue at https://www.drupal.org/project/services modules/services/src/Plugin/Deriver/EntityGet.php

catch’s picture

Status: Fixed » Active
Issue tags: +Needs manual testing, +Novice

The development tarball is now updated at https://www.drupal.org/project/drupal/releases/8.1.x-dev

Moving this back to active to encourage some manual testing. We'll probably put out 8.1.6 with this fix, which should both fix any sites that got into the situation, as well as preventing any more updates from going wrong in this particular way.

bmateus’s picture

@catch: Thanks for the heads up! Been a user of D7 for too long. This is my first D8 project, and haven't realized you can't disable modules until your reply. Thanks.

Yes, the Services error thing is now on it's own issue queue.
Thanks for your help. Drupal community is still be best part of Drupal :)

paintingguy’s picture

I feel like a dummy. I never read the update process. Doing as it says, this updated perfectly. Sorry to waste anyone's time.

Keep up the great work.

cilefen’s picture

Status: Active » Closed (works as designed)
cilefen’s picture

Status: Closed (works as designed) » Active

Sorry, the patch still needs manual testing.

catch’s picture

Status: Active » Needs review

I'd like to release 8.1.6 today if possible, since clearly lots of people don't clear out /core and /vendor when updating, and we have a viable workaround.

However I'd also really like someone other than me to manually test the patch to verify it really does fix the issue - this is impossible to actually test with the test bot (untarring a packaged release etc.)

ianthomas_uk’s picture

Title: Update from 8.13 to 8.14 breaks site seemingly permanently » Update from 8.1.3 to 8.1.4 breaks site seemingly permanently

Is it worth mentioning this under known issues at https://www.drupal.org/project/drupal/releases/8.1.5 to help anyone who is already attempting the update, and in case 8.1.6 can't be released as promptly as hoped.

catch’s picture

Added an extra note to the release notes.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs manual testing, -Novice
  • Installed 8.1.3 using the tarball.
  • Updated to 8.1.5 using the tarball and cp -R
  • Got the fatal
  • Updated to 8.1.x-dev to simulate 8.1.6
  • The fatal disappeared immediately, without any clearing of the cache

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 18: 2761865-18.patch, failed testing.

catch’s picture

Status: Needs work » Fixed

I manually tested as well as dawehner, so I've released 8.1.6: https://www.drupal.org/project/drupal/releases/8.1.6

dupal.user’s picture

Using "drush up" to update my site, it broke with
Fatal error: Class 'Drupal\locale\SourceString' not found

Would this also be fixed with 8.1.6?

alexpott’s picture

@dupal.user - Drupal\locale\SourceString has not changed since the release of 8.1.0 so upgrading should not have caused this error.

dupal.user’s picture

Thank you alexpott, I now found out the network was unstable, so the 8.1.4 update file was probably corrupted. Now, the 8.1.6 update went fine.

Concerning the use of "drush up", I just hope it deletes the directories prior to extracting the files, as the update instructions say.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.